Add attr res.array{Get,Set} to Array.{get, set}

[aspeddro]

Adding attribute because the internal representation of arr[idx] is Array.get and we don't have a way to distinguish both when issuing the token on the LSP.

See rescript-lang/rescript-vscode#801

[cknitt]

@aspeddro Shall we resurrect this PR?

Would you rebase it, add a comment somewhere explaining what the attribute is used for, and a CHANGELOG entry?

[aspeddro]

I added a comment and updated the PR

[cknitt]

Thanks a lot! 👍

Regarding the comment, I meant in the code, where this attribute is set.

Something else I am wondering about: The name res.syntaxSugar seems very generic to me. Wouldn't a more specific name like res.arrayGet/ res.arraySet be better maybe?

[aspeddro]

After a long time I made the adjustments

[cknitt]

Thanks a lot! Looks good to me!
Maybe @cristianoc or @zth would like to have a final look, too?

[cristianoc]

Looks good to me.
What is this for?

[aspeddro]

Looks good to me. What is this for?

rescript-lang/rescript-vscode#797 and
rescript-lang/rescript-vscode#801 (comment)

[cristianoc]

@aspeddro would you like to explore this on top of #7185 instead? I.e. changing the parse tree.
I'll soon add a PR demonstrating a real change to the AST, and can link it here for visibility.

[cristianoc]

This is the PR for optional fields in record type declarations: #7190
In this case of array access, I guess the extension should be lightweight and resolved very early, but after the logic for printing.