Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground 2021 #5079

Closed
wants to merge 11 commits into from
Closed

Playground 2021 #5079

wants to merge 11 commits into from

Conversation

ryyppy
Copy link
Member

@ryyppy ryyppy commented Apr 18, 2021

This time I'll do it right and keep this PR always up to date with current master, and cherry-pick the relevant playground commits into separate local branches for version specific builds

Things missing:

  • Removing the dependency to refmt (make a separate JS build artifact instead)

ryyppy added 5 commits May 7, 2022 15:40
For reference on the previous work in 2020, refer to rescript-lang#4518
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
@ryyppy ryyppy force-pushed the playground-2021 branch from dfc04db to 00ef2fb Compare May 7, 2022 13:58
@ryyppy ryyppy mentioned this pull request May 7, 2022
@ryyppy
Copy link
Member Author

ryyppy commented May 7, 2022

Closing in favour of #5375

@ryyppy ryyppy closed this May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant