Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Printer removes escaping in exotic polyvariants #265

Closed
amiralies opened this issue Feb 16, 2021 · 4 comments
Closed

Printer removes escaping in exotic polyvariants #265

amiralies opened this issue Feb 16, 2021 · 4 comments

Comments

@amiralies
Copy link
Contributor

Playground link

Hit format

@amiralies amiralies changed the title Printer removes escaping in poly exotic polyvariants Printer removes escaping in exotic polyvariants Feb 16, 2021
@IwanKaramazow
Copy link
Contributor

This seems to be a playground specific issue:
image

@ryyppy
Copy link
Member

ryyppy commented Feb 26, 2021

confirmed bug in the playground. Other related ticket: #274

ryyppy added a commit to ryyppy/rescript-compiler that referenced this issue Feb 26, 2021
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
@ryyppy
Copy link
Member

ryyppy commented Feb 26, 2021

@amiralies should now be fixed on the playground. Your original link will now work with the new 9.0.1 playground bundle.

@IwanKaramazow
Copy link
Contributor

solved =D

ryyppy added a commit to ryyppy/rescript-compiler that referenced this issue Apr 18, 2021
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
ryyppy added a commit to ryyppy/rescript-compiler that referenced this issue Apr 18, 2021
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
ryyppy added a commit to ryyppy/rescript-compiler that referenced this issue May 7, 2022
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
ryyppy added a commit to rescript-lang/rescript that referenced this issue May 31, 2022
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
ryyppy added a commit to rescript-lang/rescript that referenced this issue Jun 1, 2022
Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265
cristianoc pushed a commit to rescript-lang/rescript that referenced this issue Jun 1, 2022
* Add all relevant changes from previous 2020 bundle API

For reference on the previous work in 2020, refer to #4518

* Add ninja rule for building jsoo_refmt_main

* Fix formatting edge-cases when formatting ReScript -> ReScript

Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265

* Introduce initial type hints in playground bundle results

* Adapt playground to newest internal syntax apis

* Make jsoo_refmt_main work again by removing refmt

* Rename jsoo_refmt_main to jsoo_playground_main

* Move jsoo_playground_main to jscomp/main

* Remove irrelevant code

* Remove Refmt_api

* Make repl.js more reliable with missing .mli files

* repl.js: Log target compiler file, set js_playground_main as default

* Update CONTRIBUTING to align with the renamed playground jsoo entrypoint

Co-authored-by: Patrick Stapfer <ryyppy@users.noreply.github.com>
mununki pushed a commit to mununki/rescript-compiler that referenced this issue Jul 15, 2022
* Add all relevant changes from previous 2020 bundle API

For reference on the previous work in 2020, refer to rescript-lang#4518

* Add ninja rule for building jsoo_refmt_main

* Fix formatting edge-cases when formatting ReScript -> ReScript

Configure the parser to pass forPrinter:true when parsing / printing ReScript.
This fixes issues where e.g. Some((1, 2)) get misprinted to Some(1,2) etc.

Relevant bug reports:
- rescript-lang/syntax#274
- rescript-lang/syntax#265

* Introduce initial type hints in playground bundle results

* Adapt playground to newest internal syntax apis

* Make jsoo_refmt_main work again by removing refmt

* Rename jsoo_refmt_main to jsoo_playground_main

* Move jsoo_playground_main to jscomp/main

* Remove irrelevant code

* Remove Refmt_api

* Make repl.js more reliable with missing .mli files

* repl.js: Log target compiler file, set js_playground_main as default

* Update CONTRIBUTING to align with the renamed playground jsoo entrypoint

Co-authored-by: Patrick Stapfer <ryyppy@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants