Fix semantic highlighting

[fhammerschmidt]

This workaround brings back semantic highlighting until the referenced PR in #686 gets merged.

[zth]

What does documentSelector actually do and why do we need it to be null? And why does it work as we want without setting it? 😄

[fhammerschmidt]

A documentSelector is a list of filters to narrow the scope of the extension to e.g. a language. Which we do on the client side anyway.

The most recent version of vscode-languageserver-node however broke the precedence between client and server configuration. According to its documentation the client options should be used if the server's is null but that is not the current behaviour. Until the PR in the comment gets merged at least.

So I figured, why not just comment it out on the server? And it works.

[fhammerschmidt]

I just checked again and I now saw that they already did a fix:
microsoft/vscode-languageserver-node@8e9709d

Maybe we should just wait for their next version then.

[zth]

Can't we just use the client configuration in the server too then? Ie add what we have there instead of null?

[fhammerschmidt]

Yes, you are right that fixes it as well. I updated the PR accordingly.