Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic highlighting broken #686

Closed
fhammerschmidt opened this issue Jan 10, 2023 · 1 comment · Fixed by #693
Closed

Semantic highlighting broken #686

fhammerschmidt opened this issue Jan 10, 2023 · 1 comment · Fixed by #693

Comments

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Jan 10, 2023 •
edited
Loading

Unfortunately, my latest fix (#685) broke something else. Namely the semantic highlighting stopped working, but I already know why. I proposed a fix here: microsoft/vscode-languageserver-node#1168
This was referenced Jan 11, 2023
Merged
Merged
@fhammerschmidt
Copy link
Member Author

Works again, closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade client to fix some regressions fhammerschmidt/rescript-vscode
1 participant
@fhammerschmidt