Skip to content

Fix children type for Fragment, StrictMode and Suspense #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2023
Merged

Fix children type for Fragment, StrictMode and Suspense #94

merged 2 commits into from
May 3, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 2, 2023

Closes #93.

Also remove the experimental SuspenseList component as it is not part of the current React docs (https://react.dev/) anymore.

@cknitt cknitt requested a review from mununki May 2, 2023 08:46
@cknitt cknitt changed the title Fix children type Fix children type for Fragment, StrictMode and Suspense May 2, 2023
@cknitt cknitt mentioned this pull request May 2, 2023
Closed
@cknitt cknitt force-pushed the fix-children-type branch from 2df48b7 to 798a4a4 Compare May 2, 2023 09:06
@mununki
Copy link
Member

mununki commented May 2, 2023

Good catch!
Can we run a test on a fairly large project?

@cknitt
Copy link
Member Author

cknitt commented May 2, 2023

Can we run a test on a fairly large project?

Yes, of course, but we need a fix for rescript-lang/rescript#6234 first.

@mununki
Copy link
Member

mununki commented May 2, 2023

Can we run a test on a fairly large project?

Yes, of course, but we need a fix for rescript-lang/rescript-compiler#6234 first.

Got it. 👍

@cknitt cknitt force-pushed the fix-children-type branch from 798a4a4 to 77c8ee5 Compare May 2, 2023 13:38
mununki
mununki approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog?

@mununki mununki mentioned this pull request May 2, 2023
Merged
@cknitt
Copy link
Member Author

cknitt commented May 3, 2023

I'll update the changelog in bulk when preparing the next alpha release.

@cknitt cknitt merged commit 23f3573 into master May 3, 2023
@cknitt cknitt deleted the fix-children-type branch May 3, 2023 14:41
@cknitt cknitt mentioned this pull request Jun 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mununki mununki mununki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

children type incorrect for Fragment, StrictMode and Suspense
2 participants
@cknitt @mununki