Skip to content

children type incorrect for Fragment, StrictMode and Suspense #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cknitt opened this issue May 2, 2023 · 0 comments · Fixed by #94
Closed

children type incorrect for Fragment, StrictMode and Suspense #93

cknitt opened this issue May 2, 2023 · 0 comments · Fixed by #94

Comments

@cknitt
Copy link
Member

cknitt commented May 2, 2023

children for <>, React.Fragment, React.StrictMode and React.Suspense are typed as 'children instead of React.element.

This allows to compile incorrect code that breaks at runtime like

@react.component
let make = () => {
  <React.Suspense> 1 </React.Suspense>
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant