Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Migrate to Kotlin Gradle DSL #17

Merged
merged 2 commits into from
Sep 3, 2019
Merged

WIP: Migrate to Kotlin Gradle DSL #17

merged 2 commits into from
Sep 3, 2019

Conversation

AOrobator
Copy link
Collaborator

Continuation of #16

Renamed branch so tests could run.

@AOrobator AOrobator mentioned this pull request Sep 3, 2019
Closed
@AOrobator
Copy link
Collaborator Author

@patjackson52 This good to merge?

patjackson52
patjackson52 approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@patjackson52 patjackson52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds fine and some of the command-click follow through is working, but I am getting an error in AS saying 'Build configuration failed, run 'gradle tasks' for more info' . - have you seen this?

@AOrobator AOrobator merged commit ad19e32 into master Sep 3, 2019
@AOrobator AOrobator deleted the feature/aorobator_kotlin_gradle_dsl branch September 3, 2019 22:18
@AOrobator
Copy link
Collaborator Author

If you resync does it go away? If you invalidate caches and restart does the error still persist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patjackson52 patjackson52 patjackson52 approved these changes

Assignees

@patjackson52 patjackson52

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AOrobator @patjackson52