WIP: Migrate to Kotlin Gradle DSL #16
Conversation
| plugins { | ||
| id("de.fayard.buildSrcVersions") version "0.4.2" | ||
| } | ||
|
|
||
| apply from: "$rootDir/gradle/dependencies.gradle" |
There was a problem hiding this comment.
Eventually this line should be deleted
| /** | ||
| * https://developer.android.com/testing | ||
| */ | ||
| const val espresso_core: String = "androidx.test.espresso:espresso-core:" + Versions.espresso_core |
There was a problem hiding this comment.
I'm new to Kotlin Gradle DSL. is it convention to use snakecase? or just whatever you'd like?
There was a problem hiding this comment.
Not really sure what the convention is for Kotlin Gradle DSL, but I can't imagine it should stray too far from Kotlin conventions. In either case, this is auto-generated code that shouldn't be edited. All hand written code should strictly follow Kotlin coding conventions.
|
lgtm, just the one comment. I'd like the tests to pass. Currently the tests only run on branches with names 'feature/' or 'bugfix/' |
|
Are the test runs documented in the readme? What happens when somebody forks this repo and makes a PR? Do the tests run then? |
|
It might be easier/simpler to have tests run on all branches. I created #17 with the required branch names and am closing this one out. |
The Kotlin Gradle DSL has groovy interoperability so it can be mixed and match with groovy. Therefore this PR can be merged as is, cuz the Android example is done, but ideally, the whole project should be converted.
https://docs.gradle.org/5.6.1/userguide/kotlin_dsl.html#sec:kotlin-dsl_plugin
@patjackson52