Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1330 update non existing sheet error messages #1331

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

davidborry
Copy link
Contributor

PR Details

Update error messages for non existing sheets with proper english sentence

Description

  • Change error messages like sheetName is not exist to sheetName does not exist
  • Update comments with the same issue as well

Related Issue

#1330

Motivation and Context

Before this change, excelize would return error messages with improper english sentences when trying to access a non existing sheet. Using correct sentences would improve user experience

How Has This Been Tested

All existing tests have been updated to verify the errors messages are up to date

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1331 (40e71bf) into master (f866738) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          31       31           
  Lines       23427    23427           
=======================================
  Hits        23063    23063           
  Misses        242      242           
  Partials      122      122           
Flag Coverage Δ
unittests 98.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
styles.go 100.00% <ø> (ø)
errors.go 100.00% <100.00%> (ø)
pivotTable.go 98.72% <100.00%> (ø)
rows.go 97.39% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2022
@xuri xuri linked an issue Aug 26, 2022 that may be closed by this pull request
@xuri xuri merged commit bef49e4 into qax-os:master Aug 27, 2022
@xuri
Copy link
Member

xuri commented Aug 27, 2022

LGTM, thanks for your contribution.

xuri pushed a commit to carbin-gun/excelize that referenced this pull request Oct 9, 2022
xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper english sentence in ErrSheetNotExist message?
3 participants