Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper english sentence in ErrSheetNotExist message? #1330

Closed
davidborry opened this issue Aug 26, 2022 · 0 comments · Fixed by #1331
Closed

Improper english sentence in ErrSheetNotExist message? #1330

davidborry opened this issue Aug 26, 2022 · 0 comments · Fixed by #1331

Comments

@davidborry
Copy link
Contributor

Description
My team and I just noticed that when trying to get rows from an invalid worksheet name, we get a message like sheetName is not exist. Shouldn't it be sheetName does not exist instead?
davidborry added a commit to davidborry/excelize that referenced this issue Aug 26, 2022
@davidborry
qax-os#1330 update non existing sheet error messages
7eee59e
@davidborry davidborry mentioned this issue Aug 26, 2022
Merged
10 tasks
@xuri xuri linked a pull request Aug 26, 2022 that will close this issue
#1330 update non existing sheet error messages #1331
Merged
10 tasks
xuri pushed a commit that referenced this issue Aug 27, 2022
@davidborry
This closes #1330 update non existing sheet error messages (#1331)
bef49e4
xuri pushed a commit to carbin-gun/excelize that referenced this issue Oct 9, 2022
@davidborry @xuri
This closes qax-os#1330 update non existing sheet error messages (qax…
c6aa258 
…-os#1331)
xuri pushed a commit to JDavidVR/excelize that referenced this issue Jul 11, 2023
@davidborry @xuri
This closes qax-os#1330 update non existing sheet error messages (qax…
e95cc42 
…-os#1331)
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@davidborry
This closes qax-os#1330 update non existing sheet error messages (qax…
38ad83d 
…-os#1331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1330 update non existing sheet error messages davidborry/excelize
1 participant
@davidborry