Skip to content

gh-103786: Fix DeprecationWarnings in test_fstring. #103787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaimealonso wants to merge 3 commits into from
Closed

gh-103786: Fix DeprecationWarnings in test_fstring. #103787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16d388c
gh-103786: Fix DeprecationWarnings in test_fstring.
jaimealonso Apr 24, 2023
d43bf0c
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 24, 2023
7d1481f
Merge branch 'main' into fix-issue-103786
ambv Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Lib/test/test_fstring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,11 +963,11 @@ def test_roundtrip_raw_quotes(self):
self.assertEqual(fr'\"\'\"\'', '\\"\\\'\\"\\\'')

def test_fstring_backslash_before_double_bracket(self):
self.assertEqual(f'\{{\}}', '\\{\\}')
self.assertEqual(f'\{{', '\\{')
self.assertEqual(f'\{{{1+1}', '\\{2')
self.assertEqual(f'\}}{1+1}', '\\}2')
self.assertEqual(f'{1+1}\}}', '2\\}')
self.assertEqual(fr'\{{\}}', '\\{\\}')
self.assertEqual(fr'\{{', '\\{')
self.assertEqual(fr'\{{{1+1}', '\\{2')
self.assertEqual(fr'\}}{1+1}', '\\}2')
self.assertEqual(fr'{1+1}\}}', '2\\}')
Comment on lines +966 to +970
Copy link
Member

@sunmy2019 sunmy2019 Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fr strings are tested below. The invalid escape sequence tests are intentional.

I think you should catch the DeprecationWarning instead.

self.assertEqual(fr'\{{\}}', '\\{\\}')
self.assertEqual(fr'\{{', '\\{')
self.assertEqual(fr'\{{{1+1}', '\\{2')
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2023-04-24-18-59-06.gh-issue-103786.PCsCB0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix DeprecationWarnings in test_fstring.