gh-103786: Fix DeprecationWarnings in test_fstring. #103787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimealonso
force-pushed
the
fix-issue-103786
branch
2 times, most recently
from
cfe976b to
d43bf0c
Compare
sunmy2019
requested changes
Apr 24, 2023
Comment on lines
+966
to
+970
| self.assertEqual(fr'\{{\}}', '\\{\\}') | ||
| self.assertEqual(fr'\{{', '\\{') | ||
| self.assertEqual(fr'\{{{1+1}', '\\{2') | ||
| self.assertEqual(fr'\}}{1+1}', '\\}2') | ||
| self.assertEqual(fr'{1+1}\}}', '2\\}') |
Member
There was a problem hiding this comment.
fr strings are tested below. The invalid escape sequence tests are intentional.
I think you should catch the DeprecationWarning instead.
Member
|
It was already fixed in #104137. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103786