Add type error on filename which contain null bytes in bzopen #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

php-pulls merged 1 commit into php:master from Girgias:empty-path-bz2

Dec 8, 2019

Member

Girgias commented Dec 8, 2019

As discussed in #4984

I made it a type error like GD [1] does but I can change that to a normal warning if needed.

[1] https://php-lxr.adamharvey.name/source/xref/master/ext/gd/gd.c#4285


          Add type error on filename which contain null bytes in bzopen

cmb69 approved these changes

View reviewed changes

Member

cmb69 left a comment

This TypeError is consistent with zpp("p") behavior, so this LGTM. Thanks!

php-pulls merged commit 2741476 into php:master

Girgias deleted the empty-path-bz2 branch

December 8, 2019 19:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet