Skip to content

Convert some warnings to Errors in BZip2 #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Convert some warnings to Errors in BZip2 #4984

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 8, 2019

No description provided.

nikic
nikic reviewed Dec 8, 2019
View reviewed changes
@Girgias Girgias mentioned this pull request Dec 8, 2019
Merged
nikic
nikic reviewed Jan 3, 2020
View reviewed changes
nikic
nikic reviewed Jan 3, 2020
View reviewed changes
@Girgias Girgias force-pushed the bz2-warnings-to-error branch from cc46f1b to a3695ba Compare January 7, 2020 18:42
kocsismate
kocsismate reviewed Jan 7, 2020
View reviewed changes
@kocsismate
Copy link
Member

@cmb69 I was thinking about how to best collect all the warning promotions to a change log (regarding https://externals.io/message/107931). Wouldn't using a separate GitHub label (similar to stubs) help there?

@Girgias Girgias force-pushed the bz2-warnings-to-error branch from a3695ba to 9c612e0 Compare January 7, 2020 19:57
@cmb69
Copy link
Member

cmb69 commented Jan 7, 2020

@kocsismate, yes, I think a label would be useful. Any idea on how to name it (and which color to choose)?

@kocsismate
Copy link
Member

My preferences are Warning promotion(s) and a colour which is close to red :) But feel free to suggest a better name/colour.

@cmb69
Copy link
Member

cmb69 commented Jan 8, 2020

Is that okay?

@kocsismate
Copy link
Member

Of course! :) Thanks!

nikic
nikic approved these changes Jan 8, 2020
View reviewed changes
cmb69
cmb69 reviewed Jan 8, 2020
View reviewed changes
@php-pulls php-pulls closed this in b670823 Jan 8, 2020
@Girgias Girgias deleted the bz2-warnings-to-error branch January 8, 2020 23:59
@Girgias Girgias mentioned this pull request Aug 13, 2020
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@kocsismate kocsismate kocsismate left review comments

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Girgias @kocsismate @cmb69 @nikic