Fix GH-19371: integer overflow in calendar.c #19380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Aug 5, 2025
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (UNEXPECTED(ZEND_LONG_EXCEEDS_INT(day))) { |
There was a problem hiding this comment.
just curious. if you want to insist on INT32 ranges why not doing the range check "manually" here ?
There was a problem hiding this comment.
The code does not do +1/-1 on the day, so that's fine.
ZEND_LONG_EXCEEDS_INT will also avoid a warning on 32-bit systems where zend_long==int.
There was a problem hiding this comment.
ah yes I missed the former.. ok !
devnexen
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.