Skip to content

Commit 7d9a061

Browse files
committed
Tweak 'between' wording (our 'between' is inclusive)
1 parent 7af68f1 commit 7d9a061

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

ext/calendar/calendar.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ PHP_FUNCTION(cal_days_in_month)
195195
}
196196

197197
if (UNEXPECTED(month <= 0 || month > INT32_MAX - 1)) {
198-
zend_argument_value_error(2, "must be between 0 and %d", INT32_MAX - 1);
198+
zend_argument_value_error(2, "must be between 1 and %d", INT32_MAX - 1);
199199
RETURN_THROWS();
200200
}
201201

@@ -250,7 +250,7 @@ PHP_FUNCTION(cal_to_jd)
250250
}
251251

252252
if (UNEXPECTED(month <= 0 || month > INT32_MAX - 1)) {
253-
zend_argument_value_error(2, "must be between 0 and %d", INT32_MAX - 1);
253+
zend_argument_value_error(2, "must be between 1 and %d", INT32_MAX - 1);
254254
RETURN_THROWS();
255255
}
256256

ext/calendar/tests/gh19371.phpt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ try {
5252
?>
5353
--EXPECT--
5454
cal_days_in_month(): Argument #3 ($year) must be less than 2147483646
55-
cal_days_in_month(): Argument #2 ($month) must be between 0 and 2147483646
56-
cal_days_in_month(): Argument #2 ($month) must be between 0 and 2147483646
57-
cal_to_jd(): Argument #2 ($month) must be between 0 and 2147483646
58-
cal_to_jd(): Argument #2 ($month) must be between 0 and 2147483646
55+
cal_days_in_month(): Argument #2 ($month) must be between 1 and 2147483646
56+
cal_days_in_month(): Argument #2 ($month) must be between 1 and 2147483646
57+
cal_to_jd(): Argument #2 ($month) must be between 1 and 2147483646
58+
cal_to_jd(): Argument #2 ($month) must be between 1 and 2147483646
5959
cal_to_jd(): Argument #3 ($day) must be between -2147483648 and 2147483647
6060
cal_to_jd(): Argument #3 ($day) must be between -2147483648 and 2147483647
6161
cal_to_jd(): Argument #4 ($year) must be less than 2147483646

0 commit comments

Comments
 (0)