Avoid dl() in run-tests.php #16126
Merged
Avoid dl() in run-tests.php #16126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to running the tests, the test runner checks for all generally available extensions; it does this by scanning the `extension_dir` for files matching the typical extension pattern, but verifies that the file is actually a PHP extension by calling `dl()`. However, `dl()` has known issues[1]. On Windows CI we always get an ugly "zend_mm_heap corrupted" message, and we even can't `dl()` ext/mysql when OPcache is enabled[2]. So we better avoid the double-check with `dl()`, which is unlikely to be necessary anyway. [1] <php#9196> [2] <php#8508>
nielsdos
approved these changes
Sep 30, 2024
|
It seems this patch uncovered an issue with our PDO_Firebird builds on x86 Windows; previously, they were skipped, now they fail because pdo_firebird.dll can't be loaded. I'll have a look soon. (cc @iluuu1994) PS: see #16223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to running the tests, the test runner checks for all generally available extensions; it does this by scanning the
extension_dirfor files matching the typical extension pattern, but verifies that the file is actually a PHP extension by callingdl(). However,dl()has known issues[1]. On Windows CI we always get an ugly "zend_mm_heap corrupted" message, and we even can'tdl()ext/mysql when OPcache is enabled[2]. So we better avoid the double-check withdl(), which is unlikely to be necessary anyway.[1] #9196
[2] #8508