Try mostly static Windows build #16089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols are clashing with Wldap32.Lib which is used by ext/curl.
To avoid the excessive error reporting happening there (this should probably be properly fixed).
|
Well, this doesn't lead anywhere; besides a couple of issues (which might need to be addressed), the tests are way too slow (after 40 min the job is terminated, while they otherwise require roughly 20 min). |
This reverts commit 3e43490068a1c81947d7194687c0b2492a5116d2. Revert "Don't load mysqli which is statically built in" This reverts commit b15e4e3b16462e53be9dad9fcb8e3d9f98d98b9e. Revert "Don't error on warnings" This reverts commit 6917a6e9fbe2e8c2584330e0c1b8d89eaeaa077f. Revert "Build ldap shared" This reverts commit 4607589e46edf5ac1de9ba02d43f6f7708a31816. Revert "ldap is static" This reverts commit 06719334f818aef979e516ac4a1ed573b167e10d. Revert "Build extension static if possible" This reverts commit c30b7c77844369642bb0b768c8a7e278ee6a8980.
|
Okay, a usual build with loading all extensions by default is faster than the static build (somewhat surprising to me), but still too slow. The test failures for this configuration will be addressed by #10278, #16096, and #16098. But the main issue I was trying to cater to does not require further ado, see #16126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.