STY: Removed unconcatenated strings #30464
Conversation
ShaharNaveh
force-pushed
the
CI-str-concatenated
branch
2 times, most recently
from
3adbc5c to
c38e1ce
Compare
|
|
||
| Returns | ||
| ------- | ||
| int |
There was a problem hiding this comment.
Feels like a bool would be a more appropriate return type if this function is only ever going to return 0/1
There was a problem hiding this comment.
I did also thought so, but I am relying on an exit status, so int feels more native.
| sys.exit(0) | ||
|
|
||
|
|
||
| def is_concatenated(file_path): |
There was a problem hiding this comment.
At first I typed this whole script, but it said it was a syntax error, same with f-strings, I think that the running platform of this is python 3.5
There was a problem hiding this comment.
Hmm - we run validate_docstrings.py as part of code_checks.sh which has 3.6 + syntax?
There was a problem hiding this comment.
Hmm - we run
validate_docstrings.pyas part ofcode_checks.shwhich has 3.6 + syntax?
I really don't know.
There was a problem hiding this comment.
Hmm - we run
validate_docstrings.pyas part ofcode_checks.shwhich has 3.6 + syntax?
| tok2 = toks[i + 1] | ||
| if tok[0] == token.STRING and tok[0] == tok2[0]: | ||
| print( | ||
| "{file_path}:{line_number}:\t{start} and {end}".format( |
There was a problem hiding this comment.
Oh, I already answered above 😄
ShaharNaveh
force-pushed
the
CI-str-concatenated
branch
from
4adf8de to
d920bfd
Compare
| #!/usr/bin/env python | ||
| """ | ||
| Check where there is a string that needs to be concatenated. | ||
| """ |
There was a problem hiding this comment.
can you flesh this out with a GH reference and a sentence about how black causes the issue
|
@MomIsBestFriend do you mind opening a PR for the script and the call to the script in The fixes should be non-trivial to get merged, but not the script (I think we should try using regex for it). Thanks! |
Sure |
ShaharNaveh
changed the title
jreback
added
Code Style
|
thanks @MomIsBestFriend |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff