Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: code check for " " introduced by black #30454

Closed
jbrockmendel opened this issue Dec 24, 2019 · 1 comment · Fixed by #30467
Closed

CI: code check for " " introduced by black #30454

jbrockmendel opened this issue Dec 24, 2019 · 1 comment · Fixed by #30467
Assignees
Labels
CI Continuous Integration
Milestone

Comments

@jbrockmendel
Copy link
Member

Sometimes when we run black on something like

foo = (
    "bar "
    "baz"
)       

we end up with foo = "bar " "baz" when we would want foo = "bar baz".

This is not considered a bug in black, so is something we're currently checking for manually. We should add it to code_checks.

@alimcmaster1 alimcmaster1 added the CI Continuous Integration label Dec 24, 2019
@ShaharNaveh
Copy link
Member

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants