CLN: noqa removal #29574
Merged
CLN: noqa removal #29574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, cc @WillAyd |
jreback
added
the
Compat
jreback
approved these changes
Nov 12, 2019
| @@ -62,46 +62,46 @@ def coerce(request): | |||
| # collect all objects to be tested for list-like-ness; use tuples of objects, | |||
| # whether they are list-like or not (special casing for sets), and their ID | |||
| ll_params = [ | |||
| ([1], True, "list"), # noqa: E241 | |||
| ([], True, "list-empty"), # noqa: E241 | |||
| ((1,), True, "tuple"), # noqa: E241 | |||
There was a problem hiding this comment.
@kaathi524 what's the reason this is not necessary any more?
There was a problem hiding this comment.
@jorisvandenbossche Yeah. According to Issue #29607 , Need to remove those noqa.
jorisvandenbossche
approved these changes
Nov 14, 2019
|
@kaathi524 thanks for the PR! |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #29216