# noqa removal in code base #29216
# noqa removal in code base #29216
Conversation
|
As I removed all the |
|
Some of these are needed to pass our linting. See the output in the "Checks" CI build. That said, there are some of these (particularly non-specific "noqa"s) that are leftover from olden days and cleaning them up is definitely helpful. |
|
Where is this coming from? Do you have an issue number, or a discussion in some other PR or issue that you want to reference in the description, so we know the context? |
|
I don't think we can remove all of these - looks to be some failing CI you can keep around. I'm surprised to only see 10 in CI but maybe that's a good thing... |
|
@datapythonista this is a follow up to #29209 and particularly my comment #29209 (comment) |
There was a problem hiding this comment.
@kaathi524 to be clear you can't just blanket remove all of these. If you run flake8 locally you will see a lot of failures doing this.
Instead of doing this all at once you can also split into a few PRs to make things easier
| @@ -183,4 +183,4 @@ def time_argsort(self, N): | |||
| self.array.argsort() | |||
|
|
|||
|
|
|||
| from .pandas_vb_common import setup # noqa: F401 isort:skip | |||
| from .pandas_vb_common import setup | |||
There was a problem hiding this comment.
These can't be deleted and will still cause errors
There was a problem hiding this comment.
Okay. Will split and fix. @WillAyd
|
@kaathi524 can this be closed in favor of several smaller PRs? |
Yeah sure. I tried running flake8 in my local setup without removing any 'noqa' but it throwing error. |
|
Thanks @kaathi524, looking forward to the fixes in the smaller PRs. Please reference this PR when you open them, so we can track the discussion. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff