BLD: clean-up sdist creation #28432
Merged
BLD: clean-up sdist creation #28432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Bug
Build
|
LGTM |
WillAyd
approved these changes
Sep 13, 2019
|
@jorisvandenbossche done and passing. |
|
Whoops, this should have a release note. 1 sec. |
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -231,6 +231,8 @@ Build Changes | |||
| ^^^^^^^^^^^^^ | |||
| - Fixed pyqt development dependency issue because of different pyqt package name in conda and PyPI (:issue:`26838`) | |||
| - Added a `pyproject.toml <https://www.python.org/dev/peps/pep-0517/>`_ file (:issue:`20775`) | |||
| - Pandas no longer includes cythonized C files in the source distribution uploaded to PyPI. As long as the version of ``pip`` | |||
| supports reading a ``pyproject.toml``, no changes should be required in the build environment. The does not affect users installing wheels (:issue:`28341`). | |||
There was a problem hiding this comment.
It seems a bit strange to me to put the pyproject / cythonized files note in the "bug fixes" section, I would move it above somewhere in enhancements or changes
There was a problem hiding this comment.
Moved to a top-level section after enhancements. I removed the pyqt note, since it's a dev-only thing.
jorisvandenbossche
approved these changes
Sep 16, 2019
WillAyd
approved these changes
Sep 17, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up in https://github.com/pandas-dev/pandas/pull/28374/files#diff-2eeaed663bd0d25b7e608891384b7298R531. I meant to revert the lines that excluded cythonized files in the sdist to save it for a followup.
So I'm using this to clean up the sdist logic a bit, and exclude a few test data files that have snuck into our distribution.