Skip to content

Commit fae8177

Browse files
TomAugspurgerjorisvandenbossche
authored andcommitted
BLD: clean-up sdist creation (#28432)
1 parent 0c67f13 commit fae8177

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

MANIFEST.in

+4
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ graft pandas
1515
global-exclude *.bz2
1616
global-exclude *.csv
1717
global-exclude *.dta
18+
global-exclude *.feather
1819
global-exclude *.gz
1920
global-exclude *.h5
2021
global-exclude *.html
@@ -24,7 +25,10 @@ global-exclude *.pickle
2425
global-exclude *.png
2526
global-exclude *.pyc
2627
global-exclude *.pyd
28+
global-exclude *.ods
29+
global-exclude *.odt
2730
global-exclude *.sas7bdat
31+
global-exclude *.sav
2832
global-exclude *.so
2933
global-exclude *.xls
3034
global-exclude *.xlsm

doc/source/whatsnew/v1.0.0.rst

+9-7
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ Other enhancements
3737
(:issue:`28368`)
3838
-
3939

40+
41+
Build Changes
42+
^^^^^^^^^^^^^
43+
44+
Pandas has added a `pyproject.toml <https://www.python.org/dev/peps/pep-0517/>`_ file and will no longer include
45+
cythonized files in the source distribution uploaded to PyPI (:issue:`28341`, :issue:`20775`). If you're installing
46+
a built distribution (wheel) or via conda, this shouldn't have any effect on you. If you're building pandas from
47+
source, you should no longer need to install Cython into your build environment before calling ``pip install pandas``.
48+
4049
.. _whatsnew_1000.api_breaking:
4150

4251
Backwards incompatible API changes
@@ -227,13 +236,6 @@ Sparse
227236
-
228237
-
229238

230-
231-
Build Changes
232-
^^^^^^^^^^^^^
233-
- Fixed pyqt development dependency issue because of different pyqt package name in conda and PyPI (:issue:`26838`)
234-
- Added a `pyproject.toml <https://www.python.org/dev/peps/pep-0517/>`_ file (:issue:`20775`)
235-
236-
237239
ExtensionArray
238240
^^^^^^^^^^^^^^
239241

setup.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -522,14 +522,14 @@ def run(self):
522522
# re-compile.
523523
def maybe_cythonize(extensions, *args, **kwargs):
524524
"""
525-
Render tempita templates before calling cythonize
525+
Render tempita templates before calling cythonize. This is skipped for
526+
527+
* clean
528+
* sdist
526529
"""
527-
if len(sys.argv) > 1 and "clean" in sys.argv:
528-
# Avoid running cythonize on `python setup.py clean`
530+
if "clean" in sys.argv or "sdist" in sys.argv:
529531
# See https://github.com/cython/cython/issues/1495
530532
return extensions
531-
elif "sdist" in sys.argv:
532-
return extensions
533533

534534
numpy_incl = pkg_resources.resource_filename("numpy", "core/include")
535535
# TODO: Is this really necessary here?

0 commit comments

Comments
 (0)