CLN: remove compat.lrange, part 3 #26319
Conversation
| 'b': list('ab..'), | ||
| 'c': ['a', 'b', np.nan, 'd'], | ||
| } | ||
|
|
There was a problem hiding this comment.
Regarding the fixtures above:
These two dict patterns are used a lot in this file and because I needed to convert to list(range(4)) in all locations anyway, I just converted to use fixtures.
There was a problem hiding this comment.
let me have a look - pretty particular on fixture names
topper-123
force-pushed
the
remove_compat.lrange_III
branch
from
488d8cd to
cf1a633
Compare
Codecov Report
@@ Coverage Diff @@
## master #26319 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52291 52291
==========================================
- Hits 48132 48128 -4
- Misses 4159 4163 +4
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #26319 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52291 52291
==========================================
- Hits 48132 48128 -4
- Misses 4159 4163 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26319 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52291 52291
==========================================
- Hits 48132 48128 -4
- Misses 4159 4163 +4
Continue to review full report at Codecov.
|
|
thanks @topper-123 |
Third part of the removal of
compat.lrangefrom the code base.