CLN: remove uses of compat.lrange, part I #26281
Conversation
topper-123
force-pushed
the
clean_lrange_part_I
branch
from
1d5e451 to
0b0642c
Compare
pandas/tests/groupby/test_groupby.py
Outdated
| T = [1.0 * x for x in lrange(1, 10) * 10][:1095] | ||
| result = Series(T, lrange(0, len(T))) | ||
| T = [1.0 * x for x in list(range(1, 10)) * 10][:1095] | ||
| result = Series(T) |
There was a problem hiding this comment.
Small cleanup: Setting the index to lrange(0, len(T)) is not needed as it's just the length of the series.
Codecov Report
@@ Coverage Diff @@
## master #26281 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52379 52376 -3
==========================================
- Hits 48183 48176 -7
- Misses 4196 4200 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26281 +/- ##
==========================================
- Coverage 91.98% 91.98% -0.01%
==========================================
Files 175 175
Lines 52377 52374 -3
==========================================
- Hits 48181 48174 -7
- Misses 4196 4200 +4
Continue to review full report at Codecov.
|
topper-123
force-pushed
the
clean_lrange_part_I
branch
from
390cd56 to
6926029
Compare
|
Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-05-05 07:16:35 UTC |
topper-123
force-pushed
the
clean_lrange_part_I
branch
from
973cf72 to
b64656d
Compare
|
I've adjusted for the comments. Thanks. |
|
thanks @topper-123 |
This PR starts the removal of
compat.lrangefrom the code base. This removal requires some attention, as in most cases a plainrange(...)should be used, but in some cases alist(range(...))needs to be used.lrangeis used quite a lot, so there will be 1 or 2 more PRs, before this is removal is completed.