Add support for 303 in ngx.redirect() #849
Conversation
|
@tmthrgd Thanks for the patch! @bungle @doujiang24 @yangshuxin What do you think of this? |
|
I agree with this PR. |
t/022-redirect.t
Outdated
| === TEST 12: explicit 303 | ||
| --- config | ||
| location /read { | ||
| content_by_lua ' |
There was a problem hiding this comment.
we'd better use content_by_lua_block instead content_by_lua here :)
There was a problem hiding this comment.
That would seem sensible from my point of view. Do you want me to change that here - so the tests are changed when they're touched - or do you want me to leave this and have that done separately?
There was a problem hiding this comment.
I think it's better to change that here - we usually use *_by_lua_block for the new test cases :)
|
Yes, I think we should have this. |
|
Is this good to merge? |
|
@tmthrgd Looking good to me. Will you update the |
|
@tmthrgd Yes, please. If a new feature is not documented, users won't find it or use it. |
|
@tmthrgd Looking good to me. Thanks for your updates! Unfortunately this PR has already missed the merge window of the upcoming OpenResty release, 1.11.2.2. We have to hold this till OpenResty 1.11.2.2 is out. Sorry for the inconvenience. |
|
Will this be able to be merged for the next release? |
|
@tmthrgd Yes. Sorry for the delay on my side. Been very busy with the OpenResty conference this week. |
|
@tmthrgd Just merged into master with minor edits in your commit log message. Many thanks! |
4 participants
ngx.redirect() is missing 303 See Other support which this PR adds. This PR also adds the appropriate test case. It makes no other changes. This PR is based on #416 and 932584b.
I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.