Skip to content

Conversation

@RocFang
Copy link

@RocFang RocFang commented Aug 24, 2014

Hi, agentzh, I've being reading a book about http and http redirect, so add a 307 redirect support for ngx.redirect.

Appreciate all the work you have done!

@agentzh
Copy link
Member

agentzh commented Aug 25, 2014

@RocFang Thanks for the patch! Will you mind adding some corresponding test cases to the existing test suite?

@RocFang
Copy link
Author

RocFang commented Aug 26, 2014

@agentzh
Hi~ It's really hard work for me to make the test suite work fine in my computer, but finally I got it. Please have a check.

@agentzh
Copy link
Member

agentzh commented Aug 27, 2014

@RocFang Thank you for looking into this! Will you use the reindex script to re-format the .t files you've edited? See https://github.com/agentzh/old-openresty/blob/master/bin/reindex Thanks!

@RocFang
Copy link
Author

RocFang commented Aug 28, 2014

@agentzh
Done!
So many excellent tools!

agentzh added a commit that referenced this pull request Dec 11, 2015
…port for 307 in ngx.redirect(). thanks RocFang for the patch in #416.
@agentzh
Copy link
Member

agentzh commented Dec 11, 2015

@RocFang Sorry for the long delay on my side. I've just merged a slightly modified version of your patch to git master. Thanks for your contribution!

@agentzh agentzh closed this Dec 11, 2015
@RocFang
Copy link
Author

RocFang commented Dec 14, 2015

Thanks for your work:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants