Skip to content

implement tcpsock:getreusedtimes to get tcp infos #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

implement tcpsock:getreusedtimes to get tcp infos #1460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be06ba5
implement tcpsock:getreusedtimes to get tcp infos
jichengwang Jan 24, 2019
cdfa85a
fix cli build
jichengwang Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 116 additions & 4 deletions src/ngx_http_lua_socket_tcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ static int ngx_http_lua_socket_tcp_receive(lua_State *L);
static int ngx_http_lua_socket_tcp_receiveany(lua_State *L);
static int ngx_http_lua_socket_tcp_send(lua_State *L);
static int ngx_http_lua_socket_tcp_close(lua_State *L);
static int ngx_http_lua_socket_tcp_info(lua_State *L);
static int ngx_http_lua_socket_tcp_setoption(lua_State *L);
static int ngx_http_lua_socket_tcp_settimeout(lua_State *L);
static int ngx_http_lua_socket_tcp_settimeouts(lua_State *L);
Expand Down Expand Up @@ -236,7 +237,7 @@ ngx_http_lua_inject_socket_tcp_api(ngx_log_t *log, lua_State *L)
/* {{{req socket object metatable */
lua_pushlightuserdata(L, ngx_http_lua_lightudata_mask(
req_socket_metatable_key));
lua_createtable(L, 0 /* narr */, 5 /* nrec */);
lua_createtable(L, 0 /* narr */, 6 /* nrec */);

lua_pushcfunction(L, ngx_http_lua_socket_tcp_receive);
lua_setfield(L, -2, "receive");
Expand All @@ -250,6 +251,9 @@ ngx_http_lua_inject_socket_tcp_api(ngx_log_t *log, lua_State *L)
lua_pushcfunction(L, ngx_http_lua_socket_tcp_settimeouts);
lua_setfield(L, -2, "settimeouts"); /* ngx socket mt */

lua_pushcfunction(L, ngx_http_lua_socket_tcp_info);
lua_setfield(L, -2, "info"); /* ngx socket tcp_info*/

lua_pushvalue(L, -1);
lua_setfield(L, -2, "__index");

Expand All @@ -259,7 +263,7 @@ ngx_http_lua_inject_socket_tcp_api(ngx_log_t *log, lua_State *L)
/* {{{raw req socket object metatable */
lua_pushlightuserdata(L, ngx_http_lua_lightudata_mask(
raw_req_socket_metatable_key));
lua_createtable(L, 0 /* narr */, 6 /* nrec */);
lua_createtable(L, 0 /* narr */, 7 /* nrec */);

lua_pushcfunction(L, ngx_http_lua_socket_tcp_receive);
lua_setfield(L, -2, "receive");
Expand All @@ -276,6 +280,9 @@ ngx_http_lua_inject_socket_tcp_api(ngx_log_t *log, lua_State *L)
lua_pushcfunction(L, ngx_http_lua_socket_tcp_settimeouts);
lua_setfield(L, -2, "settimeouts"); /* ngx socket mt */

lua_pushcfunction(L, ngx_http_lua_socket_tcp_info);
lua_setfield(L, -2, "info"); /* ngx socket tcp_info*/

lua_pushvalue(L, -1);
lua_setfield(L, -2, "__index");

Expand All @@ -285,7 +292,7 @@ ngx_http_lua_inject_socket_tcp_api(ngx_log_t *log, lua_State *L)
/* {{{tcp object metatable */
lua_pushlightuserdata(L, ngx_http_lua_lightudata_mask(
tcp_socket_metatable_key));
lua_createtable(L, 0 /* narr */, 12 /* nrec */);
lua_createtable(L, 0 /* narr */, 13 /* nrec */);

lua_pushcfunction(L, ngx_http_lua_socket_tcp_connect);
lua_setfield(L, -2, "connect");
Expand Down Expand Up @@ -321,6 +328,9 @@ ngx_http_lua_inject_socket_tcp_api(ngx_log_t *log, lua_State *L)
lua_pushcfunction(L, ngx_http_lua_socket_tcp_settimeouts);
lua_setfield(L, -2, "settimeouts"); /* ngx socket mt */

lua_pushcfunction(L, ngx_http_lua_socket_tcp_info);
lua_setfield(L, -2, "info"); /* ngx socket tcp_info */

lua_pushcfunction(L, ngx_http_lua_socket_tcp_getreusedtimes);
lua_setfield(L, -2, "getreusedtimes");

Expand Down Expand Up @@ -2750,7 +2760,6 @@ ngx_http_lua_socket_tcp_receive_retval_handler(ngx_http_request_t *r,
return 1;
}


static int
ngx_http_lua_socket_tcp_close(lua_State *L)
{
Expand Down Expand Up @@ -2802,6 +2811,109 @@ ngx_http_lua_socket_tcp_close(lua_State *L)
return 1;
}

static int
ngx_http_lua_socket_tcp_info(lua_State *L) {
Copy link
Member

@agentzh agentzh Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to expose a Lua API to return the connection fd. Such information gathering features are usually platform-specific (we're not just supporting Linux or *NIX systems) and are better off to some 3rd-party Lua libraries distributed to opm (or if it's indeed good enough and popular enough, we can bundle it in OpenResty by default too). It does not have to be in the core.

Copy link

@piersoh piersoh Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is this PR: #1147 to do that - it would be handy to have one or the other.

ngx_http_request_t * r;
ngx_http_lua_socket_tcp_upstream_t *u;

if (lua_gettop(L) != 1) {
return luaL_error(L, "expecting 1 argument "
"(including the object) but seen %d", lua_gettop(L));
}

r = ngx_http_lua_get_req(L);
if (r == NULL) {
return luaL_error(L, "no request found");
}

luaL_checktype(L, 1, LUA_TTABLE);

lua_rawgeti(L, 1, SOCKET_CTX_INDEX);
u = lua_touserdata(L, -1);
lua_pop(L, 1);

if (u == NULL || u->peer.connection == NULL) {
lua_pushnil(L);
lua_pushliteral(L, "closed");
return 2;
}

if (u->request != r) {
return luaL_error(L, "bad request");
}

struct tcp_info info;
int length = sizeof(struct tcp_info);

if (getsockopt(u->peer.connection->fd, IPPROTO_TCP,
TCP_INFO, (void *) &info, (socklen_t * ) & length) != 0)
{
lua_pushnil(L);
lua_pushliteral(L, "getsockopt error");
return 2;
}
lua_pushstring(L, "test");
lua_createtable(L, 0 /* narr */, 23 /* nrec */);

lua_pushinteger(L, info.tcpi_state);
lua_setfield(L, -2, "state");
lua_pushinteger(L, info.tcpi_ca_state);
lua_setfield(L, -2, "ca_state");
lua_pushinteger(L, info.tcpi_retransmits);
lua_setfield(L, -2, "retransmits");
lua_pushinteger(L, info.tcpi_probes);
lua_setfield(L, -2, "probes");
lua_pushinteger(L, info.tcpi_backoff);
lua_setfield(L, -2, "backoff");
lua_pushinteger(L, info.tcpi_options);
lua_setfield(L, -2, "options");
lua_pushinteger(L, info.tcpi_snd_wscale);
lua_setfield(L, -2, "snd_wscale");
lua_pushinteger(L, info.tcpi_rto);
lua_setfield(L, -2, "rto");
lua_pushinteger(L, info.tcpi_ato);
lua_setfield(L, -2, "ato");
lua_pushinteger(L, info.tcpi_snd_mss);
lua_setfield(L, -2, "snd_mss");
lua_pushinteger(L, info.tcpi_rcv_mss);
lua_setfield(L, -2, "rcv_mss");
lua_pushinteger(L, info.tcpi_unacked);
lua_setfield(L, -2, "unacked");
lua_pushinteger(L, info.tcpi_sacked);
lua_setfield(L, -2, "sacked");
lua_pushinteger(L, info.tcpi_lost);
lua_setfield(L, -2, "lost");
lua_pushinteger(L, info.tcpi_retrans);
lua_setfield(L, -2, "retrans");
lua_pushinteger(L, info.tcpi_fackets);
lua_setfield(L, -2, "fackets");
lua_pushinteger(L, info.tcpi_last_data_sent);
lua_setfield(L, -2, "last_data_sent");
lua_pushinteger(L, info.tcpi_last_ack_sent);
lua_setfield(L, -2, "last_ack_sent");
lua_pushinteger(L, info.tcpi_last_data_recv);
lua_setfield(L, -2, "last_data_recv");
lua_pushinteger(L, info.tcpi_last_ack_recv);
lua_setfield(L, -2, "last_ack_recv");
lua_pushinteger(L, info.tcpi_pmtu);
lua_setfield(L, -2, "ptmu");
lua_pushinteger(L, info.tcpi_rcv_ssthresh);
lua_setfield(L, -2, "rcv_ssthresh");
lua_pushinteger(L, info.tcpi_rtt);
lua_setfield(L, -2, "rtt");
lua_pushinteger(L, info.tcpi_rttvar);
lua_setfield(L, -2, "rttvar");
lua_pushinteger(L, info.tcpi_snd_ssthresh);
lua_setfield(L, -2, "snd_ssthresh");
lua_pushinteger(L, info.tcpi_snd_cwnd);
lua_setfield(L, -2, "snd_cwnd");
lua_pushinteger(L, info.tcpi_advmss);
lua_setfield(L, -2, "advmss");
lua_pushinteger(L, info.tcpi_reordering);
lua_setfield(L, -2, "reordering");
return 1;
}


static int
ngx_http_lua_socket_tcp_setoption(lua_State *L)
Expand Down