implement tcpsock:getreusedtimes to get tcp infos #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jichengwang wants to merge 2 commits into openresty:master from union3:master

jichengwang commented Jan 24, 2019

implement tcpsock:getreusedtimes to get tcp infos


          implement tcpsock:getreusedtimes to get tcp infos

be06ba5

Contributor

tokers commented Jan 24, 2019

@jichengwang It would be better to add some tests :)


          fix cli build

cdfa85a

agentzh requested changes

View reviewed changes

src/ngx_http_lua_socket_tcp.c

    
              }

              static int

              ngx_http_lua_socket_tcp_info(lua_State *L) {

Member

agentzh Feb 4, 2019

I think we just need to expose a Lua API to return the connection fd. Such information gathering features are usually platform-specific (we're not just supporting Linux or *NIX systems) and are better off to some 3rd-party Lua libraries distributed to opm (or if it's indeed good enough and popular enough, we can bundle it in OpenResty by default too). It does not have to be in the core.

piersoh Jul 31, 2020

There is this PR: #1147 to do that - it would be handy to have one or the other.

thibaultcha force-pushed the master branch from a79e9aa to 315330a Compare

August 27, 2019 21:35

mergify bot added the needs-test-cases label

mergify bot commented Oct 23, 2020

This pull request is now in conflict :(

mergify bot added the conflict label

zhuizhuhaomeng force-pushed the master branch from f924579 to fef2581 Compare

September 20, 2021 11:01

zhuizhuhaomeng closed this

zhuizhuhaomeng reopened this

mergify bot removed the conflict label

mergify bot commented Mar 20, 2023

This pull request is now in conflict :(

mergify bot added the conflict label

mergify bot removed the conflict label

mergify bot commented May 10, 2023

This pull request is now in conflict :(

mergify bot added the conflict label

mergify bot removed the conflict label

mergify bot commented Sep 23, 2023

This pull request is now in conflict :(

mergify bot added the conflict label

mergify bot commented Mar 6, 2024

This pull request is now in conflict :(

zhuizhuhaomeng closed this

mergify bot removed the conflict label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-test-cases