Fix improper comic shortcode that causes the NumPy navbar logo to be shrunk on the "Contribute" page(s) #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
agriyakhetarpal
commented
Nov 30, 2025
| .comic { | ||
| .comic img { | ||
| max-width: 20%; | ||
| max-height: 20%; |
Contributor
Author
There was a problem hiding this comment.
We are not changing the image's aspect ratio anywhere, so the max-height rule is unnecessary and has no effect. The max-width rule will handle the height automatically.
Member
|
Thanks @agriyakhetarpal. That whole top navbar looks like it could use some tweaking. There is white space between the logo and the left border, and more white space between the logo text and the menu items. But maybe that is a problem with the theme, and not NumPy specific, since https://scipy.org/community/ looks the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
The comic shortcode currently applies a style to all images it is utilised on, so the "Contribute" pages also inherit a
max-width: 20%rule, which downsizes the NumPy logo in the navbar. Additionally, the div that applies thecomicclass to the comic cover image was being foreclosed without including the comic cover image within itself, breaking the secondary sidebar as the HTML became syntactically invalid (for context, the secondary sidebar is visible on other pages, such as the "Community" and "About Us" pages). This PR corrects these issues. See the table below for a comparison.