Skip to content

Fix improper comic shortcode that causes the NumPy navbar logo to be shrunk on the "Contribute" page(s) #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattip merged 3 commits into from
Nov 30, 2025
Merged

Fix improper comic shortcode that causes the NumPy navbar logo to be shrunk on the "Contribute" page(s) #886

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebfaceb
Apply style only to img tag inside comic class
agriyakhetarpal Nov 30, 2025
73fc626
Remove spurious foreclosing div tag
agriyakhetarpal Nov 30, 2025
79f806d
Drop unneeded `max-height: 20%` rule too
agriyakhetarpal Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions layouts/shortcodes/comic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
<div class="comic"></div>
<div class="comic">
<a href="https://heyzine.com/flip-book/3e66a13901.html">
<img src="/images/content_images/numpy-comic.png" alt="NumPy Contributor comic book cover">
</a>
</div>

<style>
.comic {
.comic img {
max-width: 20%;
max-height: 20%;
Copy link
Contributor Author

@agriyakhetarpal agriyakhetarpal Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not changing the image's aspect ratio anywhere, so the max-height rule is unnecessary and has no effect. The max-width rule will handle the height automatically.

}
img {
max-width: 20%;
max-height: 20%;
}
</style>