Closed
Conversation
PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#4538 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: nodejs#3254 PR-URL: nodejs#4540 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Adds Myles Borins and his public key to the README PR-URL: nodejs#4578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Adds Evan Lucas and his public key to the README for releases PR-URL: nodejs#4579 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
fix description about the latest LTS release download page to make it clear PR-URL: nodejs#4583 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: nodejs#4589 Fixes: nodejs#4576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
The server method returns `self` in order to allow chaining. PR-URL: nodejs#4590 Fixes: nodejs#4571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: nodejs#4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
- Changed colors to match frontpage as close as possible. - Links are slightly more horizontally padded as compared before to accomodate for the hover effect. - Slightly reduced the scroll indication height on the TOC. - The main content is now offset using margin instead of the previous border hack. - remove empty footer that was rendering a dark bar on the bottom of each page without any content. PR-URL: nodejs#4621 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Useful to have for reference, especially for onboarding PR-URL: nodejs#4636 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell<jasnell@gmail.com>
PR-URL: nodejs#4656 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: nodejs#4657 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements.
Trott
added
the
lib / src
mscdex
added
http
Contributor
Member
|
@Trott ... PR has some linting issues: https://ci.nodejs.org/job/node-test-commit/1736/ |
Contributor
|
@jasnell I'm betting those linter issues have more to do with the recently committed changes to the linter. |
Member
Author
|
Yeah, it's unlikely that this PR, which removes two lines of code and adds zero lines of code, would generate 219 linting errors. Those errors are already in v4.x-staging and were not introduced in this PR. Here's a lint run against current v4.x-staging: https://ci.nodejs.org/job/node-test-linter/859/ |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
2192fc8 to
d4a7d97
Compare
Member
|
;-) I saw the red button but didn't look into the details. /cc @thealphanerd |
Contributor
|
closing for #4688 |
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Jan 14, 2016
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: nodejs#4683 Reviewed-By: Myles Borins <mborins@us.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: #4683 Reviewed-By: Myles Borins <mborins@us.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some files in
libwere usingrequireto load modules that weresubsequently not used in the file. This removes those
requirestatements.