add the word 'Class' before incomingmessage in http docs#4589
Closed
Sequoia wants to merge 1 commit intonodejs:masterfrom
Closed
add the word 'Class' before incomingmessage in http docs#4589Sequoia wants to merge 1 commit intonodejs:masterfrom
Sequoia wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
LGTM |
jasnell
added
http
Contributor
|
LGTM, but the commit message should be updated per https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked.
Sequoia
force-pushed
the
add-class-to-incomingmessage
branch
from
a5c8051 to
e328b21
Compare
Contributor
Author
|
updated to add subsystem & check line length |
Contributor
|
LGTM, although I'm not sure the backticks in the commit message are necessary |
Contributor
|
LGTM, landed in b40aca1. And yeah, we don't usually do backticks in commit messages, no specific reason. I left them out 😉 |
Merged
Member
|
First commit to core for you @Sequoia, as far as I can tell. A small one but even minor doc fixes are always appreciated. Thanks! |
Contributor
Author
|
@rvagg the pleasure is all mine! 😸 |
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: nodejs#4589 Fixes: nodejs#4576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4576