src: remove shadowed variable in OptionsParser::Parse#46672
src: remove shadowed variable in OptionsParser::Parse#46672nodejs-github-bot merged 1 commit intonodejs:mainfrom
OptionsParser::Parse#46672Conversation
nodejs-github-bot
added
c++
|
Is there a possibility Electron could build Node.js (or Chromium) with a different set of warnings? This is more of a stylistic warning than anything else, and unless Node.js also starts adopting this warning (and probably similar ones in the future), you might end up doing a lot of changes like this. |
|
Electron already builds Node.js with a different set of warnings like enabling |
|
@addaleax fair point, though it remains fairly rare we do at the moment! in agreement with @RaisinTen above, i'd be interested in modifying a few warnings Node.js builds with to mitigate these kinds of issues: for ex. enabling |
github-actions
bot
removed
the
request-ci
|
@codebytere No strong feelings in any direction here, but I’m definitely on board with adding |
codebytere
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 97d0f77 |
PR-URL: #46672 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #46672 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #46672 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* chore: bump node in DEPS to v18.16.0 * build,test: add proper support for IBM i nodejs/node#46739 * lib: enforce use of trailing commas nodejs/node#46881 * src: add initial support for single executable applications nodejs/node#45038 * lib: do not crash using workers with disabled shared array buffers nodejs/node#41023 * src: remove shadowed variable in OptionsParser::Parse nodejs/node#46672 * src: allow embedder control of code generation policy nodejs/node#46368 * src: allow optional Isolate termination in node::Stop() nodejs/node#46583 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * chore: fixup patch indices * chore: sync filenames.json * fix: add simdutf dep to src/inspector BUILD.gn - nodejs/node#46471 - nodejs/node#46472 * deps: replace url parser with Ada nodejs/node#46410 * tls: support automatic DHE nodejs/node#46978 * fixup! src: add initial support for single executable applications * http: unify header treatment nodejs/node#46528 * fix: libc++ buffer overflow in string_view ctor nodejs/node#46410 * test: include strace openat test nodejs/node#46150 * fixup! fixup! src: add initial support for single executable applications --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
6 participants
Chromium enabled
-Wshadowin https://chromium-review.googlesource.com/c/chromium/src/+/3860569, which meant that this code caused compilation issues in Electron.Fix this with name change.