src: use simdutf utf8 to utf16 instead of icu#46471
Closed
anonrig wants to merge 3 commits intonodejs:mainfrom
Closed
src: use simdutf utf8 to utf16 instead of icu#46471anonrig wants to merge 3 commits intonodejs:mainfrom
anonrig wants to merge 3 commits intonodejs:mainfrom
Conversation
anonrig
added
the
performance
nodejs-github-bot
added
c++
anonrig
added
commit-queue-rebase
Member
Author
|
cc @nodejs/cpp-reviewers |
anonrig
added
c++
anonrig
commented
Feb 2, 2023
anonrig
force-pushed
the
improve-utf16-conversion
branch
from
3712861 to
56e4773
Compare
github-actions
bot
removed
the
request-ci
Collaborator
addaleax
approved these changes
Feb 2, 2023
anonrig
added
the
author ready
Collaborator
RafaelGSS
approved these changes
Feb 2, 2023
anonrig
added
the
commit-queue
targos
reviewed
Feb 3, 2023
Member
Author
|
Appreciate re-reviews @targos @RafaelGSS @addaleax |
github-actions
bot
removed
the
request-ci
Collaborator
addaleax
approved these changes
Feb 3, 2023
Collaborator
jasnell
approved these changes
Feb 4, 2023
Member
Author
|
Is there a bug on this pull request, or are these flaky tests? |
This was referenced Feb 5, 2023
Collaborator
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6a60ed8...8a4b1c9 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
18 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Feb 22, 2023
Many tests started failing on ARM64 Windows after migrating from icu to simdutf. This change reverts those changes for the problematic platform. Refs: nodejs#46471 Refs: nodejs#46472 Refs: nodejs#46548 Refs: simdutf/simdutf#216
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 15, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 16, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 17, 2023
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 18, 2023
* chore: bump node in DEPS to v18.16.0 * build,test: add proper support for IBM i nodejs/node#46739 * lib: enforce use of trailing commas nodejs/node#46881 * src: add initial support for single executable applications nodejs/node#45038 * lib: do not crash using workers with disabled shared array buffers nodejs/node#41023 * src: remove shadowed variable in OptionsParser::Parse nodejs/node#46672 * src: allow embedder control of code generation policy nodejs/node#46368 * src: allow optional Isolate termination in node::Stop() nodejs/node#46583 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * chore: fixup patch indices * chore: sync filenames.json * fix: add simdutf dep to src/inspector BUILD.gn - nodejs/node#46471 - nodejs/node#46472 * deps: replace url parser with Ada nodejs/node#46410 * tls: support automatic DHE nodejs/node#46978 * fixup! src: add initial support for single executable applications * http: unify header treatment nodejs/node#46528 * fix: libc++ buffer overflow in string_view ctor nodejs/node#46410 * test: include strace openat test nodejs/node#46150 * fixup! fixup! src: add initial support for single executable applications --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing one of the crucial parts with
simdutffor faster performance.