Conversation
This reverts commit 4bb4007.
nodejs-github-bot
added
lib / src
richardlau
added a commit
that referenced
this pull request
Sep 10, 2020
Notable changes: Node.js 14.10.0 included a streams regression that is being fixed in this release. PR-URL: #35137
richardlau
force-pushed
the
v14.10.1-proposal
branch
from
60099cd to
d31b12d
Compare
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/33121/ |
mmarchini
approved these changes
Sep 10, 2020
Contributor
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
Reverting the commit so we have more time to work on a long term solution sgtm
targos
approved these changes
Sep 10, 2020
2 tasks
BethGriggs
approved these changes
Sep 10, 2020
A previous change altered the rendering of visited links. This restores it. PR-URL: #35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
ronag
approved these changes
Sep 10, 2020
Notable changes: Node.js 14.10.0 included a streams regression with async generators and a docs rendering regression that are being fixed in this release. PR-URL: #35137
richardlau
force-pushed
the
v14.10.1-proposal
branch
from
d31b12d to
4c2b513
Compare
Collaborator
Member
Author
BethGriggs
approved these changes
Sep 10, 2020
richardlau
added a commit
that referenced
this pull request
Sep 10, 2020
Notable changes: Node.js 14.10.0 included a streams regression with async generators and a docs rendering regression that are being fixed in this release. PR-URL: #35137
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Sep 10, 2020
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 10, 2020
Member
Author
|
There was a release process issue that seems to have resulted in the latest symlinks not pointing to the new release. The actual files in https://nodejs.org/download/release/v14.10.1/ look okay. FYI @ljharb in case this affects I've raised nodejs/build#2432. |
Member
|
Luckily nvm doesn’t use those :-) thanks for the ping. |
Member
|
nvm for windows seems to be effected and the docs on website. |
This was referenced Sep 10, 2020
Member
Author
|
Symlinks have now been fixed. |
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Notable changes: Node.js 14.10.0 included a streams regression with async generators and a docs rendering regression that are being fixed in this release. PR-URL: nodejs#35137
targos
added
release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes
Node.js 14.10.0 included a streams regression with async generators
and a docs rendering regression that are being fixed in this release.
Commits
3c92f93b44] - doc: restore color for visited links (Rich Trott) #351080f94c6b4e4] - Revert "stream: simpler and faster Readable async iterator" (Richard Lau)@nodejs/streams @nodejs/tsc @nodejs/releasers
This proposes reverting 4bb4007 to address #35116. It sounds like more time is needed to otherwise fix the issues in both the streams code and in
gotand I think it would be better for us to getv14.xinto a stable state ahead of Tuesday's security release.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes