Closed
Conversation
A previous change altered the rendering of visited links. This restores it.
2 tasks
Member
Author
|
@aduh95 @DerekNonGeneric @nodejs/website |
Member
Author
|
This should fix this rendering:
|
tniessen
approved these changes
Sep 8, 2020
Contributor
|
People don't want to know which links they have already visited? |
DerekNonGeneric
approved these changes
Sep 9, 2020
Contributor
DerekNonGeneric
left a comment
DerekNonGeneric
left a comment
There was a problem hiding this comment.
I see now why this can result in sub-par documentation browsing experience.
fhinkel
approved these changes
Sep 9, 2020
Contributor
|
Could also use a slightly darker green for visited links. Sometimes it's a useful feature. |
Member
Author
|
Collaborators, 👍 here to fast-track to get this landed in time for the 14.10.1 release. |
richardlau
added
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35108 ✔ Done loading data for nodejs/node/pull/35108 ----------------------------------- PR info ------------------------------------ Title doc: restore color for visited links (#35108) Author Rich Trott (@Trott) Branch Trott:green -> nodejs:master Labels doc, fast-track Commits 1 - doc: restore color for visited links Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/35108 Reviewed-By: Tobias Nießen Reviewed-By: Derek Lewis Reviewed-By: Franziska Hinkelmann ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35108 Reviewed-By: Tobias Nießen Reviewed-By: Derek Lewis Reviewed-By: Franziska Hinkelmann -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected ℹ This PR was created on Tue, 08 Sep 2020 22:09:45 GMT ✔ Approvals: 3 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/35108#pullrequestreview-484529575 ✔ - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/35108#pullrequestreview-484604383 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/35108#pullrequestreview-484744498 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
github-actions
bot
added
the
commit-queue-failed
Member
|
Landed in 661b770. |
richardlau
pushed a commit
that referenced
this pull request
Sep 10, 2020
A previous change altered the rendering of visited links. This restores it. PR-URL: #35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 10, 2020
A previous change altered the rendering of visited links. This restores it. PR-URL: #35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
A previous change altered the rendering of visited links. This restores it. PR-URL: #35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
A previous change altered the rendering of visited links. This restores it. PR-URL: #35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
A previous change altered the rendering of visited links. This restores it. PR-URL: nodejs#35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
removed
the
commit-queue-failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous change altered the rendering of visited links. This restores
it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes