quic: more quic refactorings and cleanups

[jasnell]

Builds on #34262 ... that one needs to land first (the first three commits are from that PR)

• quic: replace ipv6Only option with 'udp6-only' type

  Since the ipv6Only option was mutually exclusive with
  using 'udp6', making it it's own type simplifies things
  a bit.

(more will be added)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[jasnell]

@nodejs/quic ... there's still a lot more to do on this but this PR is already fairly large and complicated so I wanted to get this one in review. There are several major pieces in here:

1. Movement to a Promises-based API. The QuicEndpoint, QuicSocket, and QuicSession classes have been moved to a Promises-based API for listen(), connect(), close(), etc. The openStream() API will also be come Promise based as well as the close() API on QuicStream. This enables code like:

const sock = createQuicSocket();
sock.on('session', (session) => {
  session.on('stream', (stream) => stream.end('hi!'));
});
await sock.listen();

and

const sock = createQuicSocket();
const client = await sock.connect();
const stream = await client.openStream();
stream.end('hello');
await client.close();

2. Improved error handling for event emitter handlers (work in progress). Previously, the error handling was rudimentary and incomplete and did not properly account for async functions used as event handlers. This starts to improve that incrementally but additional changes will come in the next PR round.

3. Improved QuicSession shutdown timing to match the spec. Previously, shutting down a QuicSession was not properly following the spec in terms of timing. There will be additional refinements made but this is much much closer to what it should be.

4. Other API cleanups. More will be coming. The next PR will focus largely on refactoring the lifecycle of QuicStream so that we can use the default autoDestroy: true, eliminate things like aborted, and generally just cleanup the implementation.

[addaleax]

If we do this, should we update net and dgram to also accept 'udp6-only'? It seems odd that we deviate from the type + ipv6Only option pairing only in this place

[jasnell]

Yes, eventually we should, yes. I just don't want to do it in this PR.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32324/
QUIC CI: https://ci.nodejs.org/job/node-test-commit/39619/

[jasnell]

CIs are good

[ruyadorno]

QUIC related, needs to be backported to v14.x 😊

[jasnell]

None of the quic related prs should be backported

[ruyadorno]

thanks for letting me know @jasnell!

I'm watching nodejs/github-bot#267 and in the meantime will update the issues I touched today to have the correct label 😊