label: mark all quic change as dont-land-v14.x#267
Merged
MylesBorins merged 1 commit intonodejs:masterfrom Jul 29, 2020
Merged
Conversation
mmarchini
approved these changes
Jul 22, 2020
Member
|
@MylesBorins That also implies we should add the other dont-land-* labels (e.g. |
jasnell
approved these changes
Jul 22, 2020
Contributor
Author
|
I've added the |
4 tasks
targos
requested changes
Jul 22, 2020
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
The labels are dont-land-on-vnn.x
MylesBorins
force-pushed
the
quic-dont-land-v14.x
branch
from
edc9f13 to
86bdfe3
Compare
As per discussion on GitHub it does not appear that QUIC is intended to be backported to v14.x, add appropriate label.
MylesBorins
force-pushed
the
quic-dont-land-v14.x
branch
from
86bdfe3 to
3b6c4bd
Compare
richardlau
approved these changes
Jul 29, 2020
phillipj
approved these changes
Jul 29, 2020
Contributor
Author
|
@targos PTAL |
targos
approved these changes
Jul 29, 2020
Contributor
Author
|
is there anything else we need to do to deploy this? Do we have CD in place? |
Member
|
CD is setup, yes. The bot automatically gets deployed when changes lands in master 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion on GitHub it does not appear that QUIC is intended
to be backported to v14.x, add appropriate label.
/cc @jasnell to confirm