[v12 backport] lib: no need to strip BOM or shebang for scripts#31228
Closed
aduh95 wants to merge 2 commits intonodejs:v12.x-stagingfrom
Closed
[v12 backport] lib: no need to strip BOM or shebang for scripts#31228aduh95 wants to merge 2 commits intonodejs:v12.x-stagingfrom
aduh95 wants to merge 2 commits intonodejs:v12.x-stagingfrom
Conversation
nodejs-github-bot
added
lib / src
Fixes nodejs#27767 PR-URL: nodejs#27768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
force-pushed
the
backport-27768-to-erbium
branch
from
978378f to
6667b45
Compare
PR-URL: nodejs#27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95
force-pushed
the
backport-27768-to-erbium
branch
from
6667b45 to
7100e23
Compare
2 tasks
Contributor
|
/cc @targos should this land separately from the bump to 7.9? |
Collaborator
Member
|
I'll have to look at it in detail. As I said in #27768, it was partially reverted in a change that landed in v12.x already. |
Contributor
|
Wasn't the original change Semver-Major? can we land this without causing any issues? |
Contributor
3 tasks
targos
approved these changes
Jan 8, 2020
Member
|
The changes LGTM and the new lines in @devsnek wdyt? |
Member
targos
pushed a commit
that referenced
this pull request
Jan 8, 2020
Backport-PR-URL: #31228 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 8, 2020
Backport-PR-URL: #31228 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Backport-PR-URL: #31228 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331b (which was introduced with 7.5 upgrade).EDIT: I get this part wrong... As of V8 7.4, V8 implements the Hashbang Grammar proposal by default, so 702331b removed custom code that handled hashbang for scripts. As far as I can see, it has not been backported to v12 yet.I'm also backporting #27768 to ease the conflict resolution.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes