Skip to content

deps: update V8 to 7.5#27375

Merged
refack merged 22 commits intonodejs:masterfrom
targos:v8-7.5
Jun 1, 2019
Merged

deps: update V8 to 7.5#27375
refack merged 22 commits intonodejs:masterfrom
targos:v8-7.5

Conversation

@targos
Copy link
Member

@targos targos commented Apr 23, 2019 •
edited
Loading

Help wanted to fix remaining failures!

See #27375 (comment)

@targos targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. labels Apr 23, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3346

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Apr 23, 2019
@targos targos added blocked PRs that are blocked by other issues or PRs. and removed build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Apr 23, 2019
ryzokuken
ryzokuken approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

Thanks, @targos.

@refack
Copy link
Contributor

refack commented Apr 23, 2019 •
edited
Loading

image
😄 what a happy little group

@targos
Copy link
Member Author

targos commented Apr 23, 2019

Wait, it didn't fail on linuxone? Let me start a full CI...

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22666/

@refack
Copy link
Contributor

refack commented Apr 23, 2019

Wait, it didn't fail on linuxone? Let me start a full CI...

It's a liker issue, so it could arise from several reasons; (1) old compiled artifacts (2) C++ template mismatch (3) #ifdef...

@targos
Copy link
Member Author

targos commented Apr 23, 2019

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2252/

@targos
Copy link
Member Author

targos commented Apr 23, 2019

I think we can exclude (1). I can reproduce after a git clean -fdx

@targos
Copy link
Member Author

targos commented Apr 23, 2019

macOS:

22:20:58 ../deps/v8/src/torque/torque-compiler.cc:114:3: error: cannot use 'try' with exceptions disabled
22:20:58   try {
22:20:58   ^
22:20:58 ../deps/v8/src/torque/torque-compiler.cc:132:3: error: cannot use 'try' with exceptions disabled
22:20:58   try {
22:20:58   ^
22:20:58 2 errors generated.
22:20:58 make[2]: *** [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1011/out/Release/obj.host/torque_base/deps/v8/src/torque/torque-compiler.o] Error 1

I fixed that issue on Linux with d46ee3e#diff-30246878345a874b2105006560a03f27R2530

@targos
Copy link
Member Author

targos commented Apr 23, 2019

Errors on Windows:

Details 
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "class v8::internal::Isolate * __cdecl v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned __int64)" (?IsolateFromNeverReadOnlySpaceObject@internal@v8@@YAPEAVIsolate@12@_K@Z) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8::Context::GetEmbedderData(int)" (?GetEmbedderData@Context@v8@@QEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "class v8::internal::Isolate * __cdecl v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned __int64)" (?IsolateFromNeverReadOnlySpaceObject@internal@v8@@YAPEAVIsolate@12@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "class v8::internal::Isolate * __cdecl v8::internal::IsolateFromNeverReadOnlySpaceObject(unsigned __int64)" (?IsolateFromNeverReadOnlySpaceObject@internal@v8@@YAPEAVIsolate@12@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(void)" (??1HandleScope@v8@@QEAA@XZ) referenced in function "public: __cdecl v8::EscapableHandleScope::~EscapableHandleScope(void)" (??1EscapableHandleScope@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(void)" (??1HandleScope@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::HandleScope::~HandleScope(void)" (??1HandleScope@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "protected: static unsigned __int64 * __cdecl v8::HandleScope::CreateHandle(class v8::internal::Isolate *,unsigned __int64)" (?CreateHandle@HandleScope@v8@@KAPEA_KPEAVIsolate@internal@2@_K@Z) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8::Context::GetEmbedderData(int)" (?GetEmbedderData@Context@v8@@QEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "protected: static unsigned __int64 * __cdecl v8::HandleScope::CreateHandle(class v8::internal::Isolate *,unsigned __int64)" (?CreateHandle@HandleScope@v8@@KAPEA_KPEAVIsolate@internal@2@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "protected: static unsigned __int64 * __cdecl v8::HandleScope::CreateHandle(class v8::internal::Isolate *,unsigned __int64)" (?CreateHandle@HandleScope@v8@@KAPEA_KPEAVIsolate@internal@2@_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl v8::ScriptCompiler::ExternalSourceStream::SetBookmark(void)" (?SetBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ScriptCompiler::ExternalSourceStream::ResetToBookmark(void)" (?ResetToBookmark@ExternalSourceStream@ScriptCompiler@v8@@UEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<bool> __cdecl v8::ValueSerializer::Delegate::WriteHostObject(class v8::Isolate *,class v8::Local<class v8::Object>)" (?WriteHostObject@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@_N@3@PEAVIsolate@3@V?$Local@VObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayBuffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBuffer@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayBuffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBuffer@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetSharedArrayBufferId(class v8::Isolate *,class v8::Local<class v8::SharedArrayBuffer>)" (?GetSharedArrayBufferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VSharedArrayBuffer@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmModuleObject>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmModuleObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmModuleObject>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmModuleObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::Maybe<unsigned int> __cdecl v8::ValueSerializer::Delegate::GetWasmModuleTransferId(class v8::Isolate *,class v8::Local<class v8::WasmModuleObject>)" (?GetWasmModuleTransferId@Delegate@ValueSerializer@v8@@UEAA?AV?$Maybe@I@3@PEAVIsolate@3@V?$Local@VWasmModuleObject@v8@@@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSerializer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@ValueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSerializer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@ValueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual void * __cdecl v8::ValueSerializer::Delegate::ReallocateBufferMemory(void *,unsigned __int64,unsigned __int64 *)" (?ReallocateBufferMemory@Delegate@ValueSerializer@v8@@UEAAPEAXPEAX_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerializer::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerializer::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl v8::ValueSerializer::Delegate::FreeBufferMemory(void *)" (?FreeBufferMemory@Delegate@ValueSerializer@v8@@UEAAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::Object> __cdecl v8::ValueDeserializer::Delegate::ReadHostObject(class v8::Isolate *)" (?ReadHostObject@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VObject@v8@@@3@PEAVIsolate@3@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::WasmModuleObject> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmModuleObject@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::WasmModuleObject> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmModuleObject@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::WasmModuleObject> __cdecl v8::ValueDeserializer::Delegate::GetWasmModuleFromId(class v8::Isolate *,unsigned int)" (?GetWasmModuleFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VWasmModuleObject@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: virtual class v8::MaybeLocal<class v8::SharedArrayBuffer> __cdecl v8::ValueDeserializer::Delegate::GetSharedArrayBufferFromId(class v8::Isolate *,unsigned int)" (?GetSharedArrayBufferFromId@Delegate@ValueDeserializer@v8@@UEAA?AV?$MaybeLocal@VSharedArrayBuffer@v8@@@3@PEAVIsolate@3@I@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) referenced in function "public: void __cdecl v8::Template::Set(class v8::Isolate *,char const *,class v8::Local<class v8::Data>)" (?Set@Template@v8@@QEAAXPEAVIsolate@2@PEBDV?$Local@VData@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: static class v8::MaybeLocal<class v8::String> __cdecl v8::String::NewFromUtf8(class v8::Isolate *,char const *,enum v8::NewStringType,int)" (?NewFromUtf8@String@v8@@SA?AV?$MaybeLocal@VString@v8@@@2@PEAVIsolate@2@PEBDW4NewStringType@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResourceSlow(void)const " (?GetExternalStringResourceSlow@String@v8@@AEBAPEAVExternalStringResource@12@XZ) referenced in function "public: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResource(void)const " (?GetExternalStringResource@String@v8@@QEBAPEAVExternalStringResource@12@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResourceSlow(void)const " (?GetExternalStringResourceSlow@String@v8@@AEBAPEAVExternalStringResource@12@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResource * __cdecl v8::String::GetExternalStringResourceSlow(void)const " (?GetExternalStringResourceSlow@String@v8@@AEBAPEAVExternalStringResource@12@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBaseSlow(enum v8::String::Encoding *)const " (?GetExternalStringResourceBaseSlow@String@v8@@AEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) referenced in function "public: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBase(enum v8::String::Encoding *)const " (?GetExternalStringResourceBase@String@v8@@QEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBaseSlow(enum v8::String::Encoding *)const " (?GetExternalStringResourceBaseSlow@String@v8@@AEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: class v8::String::ExternalStringResourceBase * __cdecl v8::String::GetExternalStringResourceBaseSlow(enum v8::String::Encoding *)const " (?GetExternalStringResourceBaseSlow@String@v8@@AEBAPEAVExternalStringResourceBase@12@PEAW4Encoding@12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCount(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) referenced in function "public: static int __cdecl v8::Object::InternalFieldCount(class v8::PersistentBase<class v8::Object> const &)" (?InternalFieldCount@Object@v8@@SAHAEBV?$PersistentBase@VObject@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCount(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: int __cdecl v8::Object::InternalFieldCount(void)" (?InternalFieldCount@Object@v8@@QEAAHXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) referenced in function "public: static class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(class v8::PersistentBase<class v8::Object> const &)" (?CreationContext@Object@v8@@SA?AV?$Local@VContext@v8@@@2@AEBV?$PersistentBase@VObject@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: class v8::Local<class v8::Context> __cdecl v8::Object::CreationContext(void)" (?CreationContext@Object@v8@@QEAA?AV?$Local@VContext@v8@@@2@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: class v8::Local<class v8::Value> __cdecl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8::Object::GetInternalField(int)" (?GetInternalField@Object@v8@@QEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: class v8::Local<class v8::Value> __cdecl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: class v8::Local<class v8::Value> __cdecl v8::Object::SlowGetInternalField(int)" (?SlowGetInternalField@Object@v8@@AEAA?AV?$Local@VValue@v8@@@2@H@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlignedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) referenced in function "public: void * __cdecl v8::Object::GetAlignedPointerFromInternalField(int)" (?GetAlignedPointerFromInternalField@Object@v8@@QEAAPEAXH@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlignedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void * __cdecl v8::Object::SlowGetAlignedPointerFromInternalField(int)" (?SlowGetAlignedPointerFromInternalField@Object@v8@@AEAAPEAXH@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z) referenced in function "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: class v8::MaybeLocal<class v8::Object> __cdecl v8::Function::NewInstance(class v8::Local<class v8::Context>,int,class v8::Local<class v8::Value> * const)const " (?NewInstance@Function@v8@@QEBA?AV?$MaybeLocal@VObject@v8@@@2@V?$Local@VContext@v8@@@2@HQEAV?$Local@VValue@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: bool __cdecl v8::ArrayBuffer::IsDetachable(void)const " (?IsDetachable@ArrayBuffer@v8@@QEBA_NXZ) referenced in function "public: bool __cdecl v8::ArrayBuffer::IsNeuterable(void)const " (?IsNeuterable@ArrayBuffer@v8@@QEBA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: bool __cdecl v8::ArrayBuffer::IsDetachable(void)const " (?IsDetachable@ArrayBuffer@v8@@QEBA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: bool __cdecl v8::ArrayBuffer::IsDetachable(void)const " (?IsDetachable@ArrayBuffer@v8@@QEBA_NXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::ArrayBuffer::Detach(void)" (?Detach@ArrayBuffer@v8@@QEAAXXZ) referenced in function "public: void __cdecl v8::ArrayBuffer::Neuter(void)" (?Neuter@ArrayBuffer@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ArrayBuffer::Detach(void)" (?Detach@ArrayBuffer@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ArrayBuffer::Detach(void)" (?Detach@ArrayBuffer@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@VName@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) referenced in function "public: void __cdecl v8::Template::Set(class v8::Isolate *,char const *,class v8::Local<class v8::Data>)" (?Set@Template@v8@@QEAAXPEAVIsolate@2@PEBDV?$Local@VData@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@VName@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Template::Set(class v8::Local<class v8::Name>,class v8::Local<class v8::Data>,enum v8::PropertyAttribute)" (?Set@Template@v8@@QEAAXV?$Local@VName@v8@@@2@V?$Local@VData@v8@@@2@W4PropertyAttribute@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHandler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyHandlerConfiguration@2@@Z) referenced in function "public: void __cdecl v8::ObjectTemplate::SetIndexedPropertyHandler(void (__cdecl*)(unsigned int,class v8::PropertyCallbackInfo<class v8::Value> const &),void (__cdecl*)(unsigned int,class v8::Local<class v8::Value>,class v8::PropertyCallbackInfo<class v8::Value> const &),void (__cdecl*)(unsigned int,class v8::PropertyCallbackInfo<class v8::Integer> const &),void (__cdecl*)(unsigned int,class v8::PropertyCallbackInfo<class v8::Boolean> const &),void (__cdecl*)(class v8::PropertyCallbackInfo<class v8::Array> const &),class v8::Local<class v8::Value>)" (?SetIndexedPropertyHandler@ObjectTemplate@v8@@QEAAXP6AXIAEBV?$PropertyCallbackInfo@VValue@v8@@@2@@ZP6AXIV?$Local@VValue@v8@@@2@0@ZP6AXIAEBV?$PropertyCallbackInfo@VInteger@v8@@@2@@ZP6AXIAEBV?$PropertyCallbackInfo@VBoolean@v8@@@2@@ZP6AXAEBV?$PropertyCallbackInfo@VArray@v8@@@2@@Z2@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHandler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyHandlerConfiguration@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::ObjectTemplate::SetHandler(struct v8::IndexedPropertyHandlerConfiguration const &)" (?SetHandler@ObjectTemplate@v8@@QEAAXAEBUIndexedPropertyHandlerConfiguration@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)" (?Enter@Isolate@v8@@QEAAXXZ) referenced in function "public: __cdecl v8::Isolate::Scope::Scope(class v8::Isolate *)" (??0Scope@Isolate@v8@@QEAA@PEAV12@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)" (?Enter@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Enter(void)" (?Enter@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (?Exit@Isolate@v8@@QEAAXXZ) referenced in function "public: __cdecl v8::Isolate::Scope::~Scope(void)" (??1Scope@Isolate@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (?Exit@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::Isolate::Exit(void)" (?Exit@Isolate@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExternalAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) referenced in function "public: __int64 __cdecl v8::Isolate::AdjustAmountOfExternalAllocatedMemory(__int64)" (?AdjustAmountOfExternalAllocatedMemory@Isolate@v8@@QEAA_J_J@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExternalAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::ReportExternalAllocationLimitReached(void)" (?ReportExternalAllocationLimitReached@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryPressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) referenced in function "public: __int64 __cdecl v8::Isolate::AdjustAmountOfExternalAllocatedMemory(__int64)" (?AdjustAmountOfExternalAllocatedMemory@Isolate@v8@@QEAA_J_J@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryPressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Isolate::CheckMemoryPressure(void)" (?CheckMemoryPressure@Isolate@v8@@AEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: static unsigned __int64 * __cdecl v8::V8::CopyGlobalReference(unsigned __int64 *)" (?CopyGlobalReference@V8@v8@@CAPEA_KPEA_K@Z) referenced in function "private: __cdecl v8::WasmModuleObjectBuilderStreaming::WasmModuleObjectBuilderStreaming(class v8::WasmModuleObjectBuilderStreaming &&)" (??0WasmModuleObjectBuilderStreaming@v8@@AEAA@$$QEAV01@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: static unsigned __int64 * __cdecl v8::V8::CopyGlobalReference(unsigned __int64 *)" (?CopyGlobalReference@V8@v8@@CAPEA_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: static unsigned __int64 * __cdecl v8::V8::CopyGlobalReference(unsigned __int64 *)" (?CopyGlobalReference@V8@v8@@CAPEA_KPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlobal(unsigned __int64 *)" (?DisposeGlobal@V8@v8@@CAXPEA_K@Z) referenced in function "public: __cdecl v8::WasmModuleObjectBuilderStreaming::~WasmModuleObjectBuilderStreaming(void)" (??1WasmModuleObjectBuilderStreaming@v8@@QEAA@XZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlobal(unsigned __int64 *)" (?DisposeGlobal@V8@v8@@CAXPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::DisposeGlobal(unsigned __int64 *)" (?DisposeGlobal@V8@v8@@CAXPEA_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmpty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) referenced in function "public: void __cdecl v8::Template::Set(class v8::Isolate *,char const *,class v8::Local<class v8::Data>)" (?Set@Template@v8@@QEAAXPEAVIsolate@2@PEBDV?$Local@VData@v8@@@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmpty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: static void __cdecl v8::V8::ToLocalEmpty(void)" (?ToLocalEmpty@V8@v8@@CAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCreator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) referenced in function "public: void __cdecl v8::SnapshotCreator::`default constructor closure'(void)" (??_FSnapshotCreator@v8@@QEAAXXZ) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCreator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: __cdecl v8::SnapshotCreator::SnapshotCreator(__int64 const *,class v8::StartupData *)" (??0SnapshotCreator@v8@@QEAA@PEB_JPEAVStartupData@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) referenced in function "public: __cdecl v8::Unlocker::Unlocker(class v8::Isolate *)" (??0Unlocker@v8@@QEAA@PEAVIsolate@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Unlocker::Initialize(class v8::Isolate *)" (?Initialize@Unlocker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(class v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) referenced in function "public: __cdecl v8::Locker::Locker(class v8::Isolate *)" (??0Locker@v8@@QEAA@PEAVIsolate@1@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(class v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "private: void __cdecl v8::Locker::Initialize(class v8::Isolate *)" (?Initialize@Locker@v8@@AEAAXPEAVIsolate@2@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: static void * __cdecl v8::internal::Malloced::New(unsigned __int64)" (?New@Malloced@internal@v8@@SAPEAX_K@Z) referenced in function "public: static void * __cdecl v8::internal::Malloced::operator new(unsigned __int64)" (??2Malloced@internal@v8@@SAPEAX_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: static void * __cdecl v8::internal::Malloced::New(unsigned __int64)" (?New@Malloced@internal@v8@@SAPEAX_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: static void * __cdecl v8::internal::Malloced::New(unsigned __int64)" (?New@Malloced@internal@v8@@SAPEAX_K@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: static void __cdecl v8::internal::Malloced::Delete(void *)" (?Delete@Malloced@internal@v8@@SAXPEAX@Z) referenced in function "public: static void __cdecl v8::internal::Malloced::operator delete(void *)" (??3Malloced@internal@v8@@SAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: static void __cdecl v8::internal::Malloced::Delete(void *)" (?Delete@Malloced@internal@v8@@SAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: static void __cdecl v8::internal::Malloced::Delete(void *)" (?Delete@Malloced@internal@v8@@SAXPEAX@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 generate-bytecodes-builtins-list.obj : error LNK2019: unresolved external symbol "public: void __cdecl v8::internal::VirtualMemory::TakeControl(class v8::internal::VirtualMemory *)" (?TakeControl@VirtualMemory@internal@v8@@QEAAXPEAV123@@Z) referenced in function "public: __cdecl v8::internal::VirtualMemory::VirtualMemory(class v8::internal::VirtualMemory &&)" (??0VirtualMemory@internal@v8@@QEAA@$$QEAV012@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecode-operands.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::VirtualMemory::TakeControl(class v8::internal::VirtualMemory *)" (?TakeControl@VirtualMemory@internal@v8@@QEAAXPEAV123@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 bytecodes.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::VirtualMemory::TakeControl(class v8::internal::VirtualMemory *)" (?TakeControl@VirtualMemory@internal@v8@@QEAAXPEAV123@@Z) [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]
22:22:56 ..\..\out\Release\bytecode_builtins_list_generator.exe : fatal error LNK1120: 38 unresolved externals [c:\workspace\node-compile-windows\tools\v8_gypfiles\bytecode_builtins_list_generator.vcxproj]

@refack

This comment has been minimized.

Sign in to view
@vsemozhetbyt vsemozhetbyt added the v8 engine Issues and PRs related to the V8 dependency. label Apr 23, 2019
@refack
Copy link
Contributor

refack commented Apr 23, 2019

plinux i.e. gcc-6 on ubuntu1404 over PPC64-LE:

  LD_LIBRARY_PATH=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/lib.host:/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/v8_gypfiles; mkdir -p /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/generate_snapshot/geni; "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/mksnapshot" --turbo_instruction_scheduling --embedded_variant Default --embedded_src "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/generate_snapshot/geni/embedded.S" --startup_src "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/generate_snapshot/geni/snapshot.cc"
Segmentation fault (core dumped)

@refack
Copy link
Contributor

refack commented Apr 23, 2019

Well, there a bit of more gyp refactoring needed to mirror the changes in BUILD.gn https://github.com/nodejs/node/blob/2fef4d2f22b9f42042dcd96374e01dfc736bd782/deps/v8/BUILD.gn#diff-75477e7cdd271be767e5255488ca45e1.
A few of the dependencies have been moved around... I'll get to it soon.

@refack refack self-assigned this Apr 23, 2019
@richardlau
Copy link
Member

richardlau commented Apr 24, 2019

node/tools/icu/icu_versions.json

Line 2 in 1a54d0f

"minimum_icu": 63
should be bumped in this PR to raise the minimum supported version of ICU.

@BridgeAR
Copy link
Member

BridgeAR commented Apr 24, 2019

@targos did we not plan to land 7.5 in v12? Or are we going to open a special backport later that contains commits to make it ABI compatible?

@richardlau
Copy link
Member

richardlau commented Apr 24, 2019

@targos did we not plan to land 7.5 in v12? Or are we going to open a special backport later that contains commits to make it ABI compatible?

@BridgeAR see #25082.

@targos
Copy link
Member Author

targos commented Apr 24, 2019

@BridgeAR The latter. Let's make it work without changes first.

srl295
srl295 previously requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete obsolete ICU patches

ryzokuken
ryzokuken approved these changes Apr 27, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests pass w/ refack@6720bd3

Xcode 10.2.1
Build version 10E1001
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.5.0
Thread model: posix

@refack

This comment has been minimized.

Sign in to view
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 20, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
9ffc134 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 21, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
a2ee52f 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 21, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
1f5d827 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 22, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
3a3b2fa 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 22, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
53973f3 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 23, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
4222813 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 23, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
1826d56 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 24, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
ddb9075 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 24, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
2a0ea94 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 25, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
0e68ec0 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 25, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
f08b588 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 26, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
10edc26 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 26, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
a8af49b 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 27, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
b690141 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 27, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
9e20ea5 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 28, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
9ce8519 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 28, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
69e9e55 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 29, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
f45358b 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Feb 29, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
7b0fc17 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Mar 1, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
87e910b 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Mar 1, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
f665fe0 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Mar 2, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
b62a99b 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Mar 2, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
de855bd 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Mar 3, 2020
@refack @nodejs-ci
deps: V8: patch register-arm64.h
3cb0f84 
Fixes a compilation issue on some platforms

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Mar 3, 2020
@refack @nodejs-ci
deps: V8: forward declaration of Rtl*FunctionTable
4df4620 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@bcoe bcoe mentioned this pull request Oct 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 left review comments

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@refack refack refack approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.