Conversation
mscdex
added
the
npm
Member
|
Please hold off on merging this one in, there'll be a node-gyp@3.0.2 shortly to fix a bug that should go in here. I'll update here when that's done. |
Member
|
node-gyp@3.0.2 is published, @zkat if you're around could you update your PR to replace the second commit with 3.0.2 please? otherwise if someone else is going to land this, just do @zkat's first commit then make a second with |
Contributor
|
This has got to be the easiest npm pr to review ever. LGTM with node-gyp@3.0.2 |
No more cherry-picked io patches. hooray.
Contributor
Author
|
node-gyp updated to 3.0.3. :) |
Member
|
LGTM so long as the bundled npm tests all pass :-) |
Contributor
|
I'll look at this soon. |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 15, 2015
PR-URL: #2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 15, 2015
No more cherry-picked io patches. hooray. PR-URL: #2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
Landed in 1f842c2...3351305 -- thanks! |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 15, 2015
PR-URL: #2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 15, 2015
No more cherry-picked io patches. hooray. PR-URL: #2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg
pushed a commit
that referenced
this pull request
Sep 15, 2015
PR-URL: #2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg
pushed a commit
that referenced
this pull request
Sep 15, 2015
No more cherry-picked io patches. hooray. PR-URL: #2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Sep 17, 2015
Notable changes: * buffer: - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) nodejs#2866. - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) nodejs#2777. * fs: - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) nodejs#2387. - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) nodejs#2167. * http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) nodejs#2824. * npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) nodejs#2822. * src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) nodejs#2324. * v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) nodejs#2870. - This fixes a previously known bug where some computed object shorthand properties did not work correctly (nodejs#2507). Refs: nodejs#2844 PR-URL: nodejs#2889
Fishrock123
added a commit
that referenced
this pull request
Sep 17, 2015
Notable changes: * buffer: - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) #2866. - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) #2777. * fs: - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) #2387. - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) #2167. * http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) #2824. * npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) #2822. * src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) #2324. * v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) #2870. - This fixes a previously known bug where some computed object shorthand properties did not work correctly (#2507). Refs: #2844 PR-URL: #2889
Contributor
|
landed in lts-v4.x staging as 816f609...2600fb8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yay! New npm for node 4 :)
There's not much in this release that would affect node except a patch to our test suite to make the released version of npm pass its tests (which is what stopped the release 2 weeks ago from getting upstreamed).
Additionally, I've manually included an upgrade so we use
node-gyp@3.0.3, which isn't officially part of this release but will be included in next week's (and is currently innpm@next).See our release notes at https://github.com/npm/npm/releases/tag/v2.14.3
r: @Fishrock123
r: @chrisdickinson