Conversation
0cd7d38 to
edc2860
Compare
|
@rvagg a6cb3a5719 should be in too? |
|
@rvagg also isn't def8dea8ac for V8 4.5? |
|
I left a6cb3a5 because it applies to node.1 and we're on iojs.1 and frankly couldn't be bothered dealing with that; if you're up to it then feel free, I just didn't see it as essential but maybe I'm being too relaxed about v3. I don't believe def8dea8ac is strictly about v4.5, it should apply to 4.4 as well, it compiles but I could be misunderstanding it. https://ci.nodejs.org/job/node-test-commit/507/ is against current v3.x. |
Personally I'd prefer if it was. Heck even if you do a rename to node.1, apply, then re-name again, then squash. I don't have the bandwidth with nodeconf.eu flight and such tomorrow |
|
Can we get #2696 pulled in, so 3.x branch will be also fixed? |
|
yeah, it'll go in, and we should be able to float the same node-gyp patch that we're shipping with v4 so our old floating patches become redundant now |
edc2860 to
8f0caa7
Compare
|
With 4.x approaching, are we still pushing forward with v3.3.1? |
|
open question, I think so but others may disagree .. ? |
|
@evanlucas I would prefer if 3.x branch at least got an npm update :-). Updated: So that's a +1 for 3.3.1. |
|
Sounds good to me. Does 3.3.0 include the npm that has the security update? |
|
@evanlucas v3.3.0 has old npm, 2.13.3. |
|
+1 on 3.3.1 |
|
Ah, yea. I'm +1 also |
8f0caa7 to
ac320fa
Compare
|
Updated this branch and OP to reflect current v3.x branch and the diff with master, I'll push this out on Monday unless someone else in @nodejs/release wants to try their hand at a release that's mostly ready to go? |
ac320fa to
20d9e78
Compare
|
Updated OP to reflect current 3.x branch status and moving forward with this release. One omission from this branch because I personally think it's borderline semver-minor and without that being resolved I'd like to leave it out, is:
The rest of the 3.x / master diff can be seen in OP. CI run for v3.x HEAD happening https://ci.nodejs.org/job/node-test-commit/578/ |
|
failures on smartos-64 and freebsd-64 are known flaky |
* buffer: Fixed a minor errors that was causing crashes (Michaël Zasso) #2635, * child_process: Fix error that was causing crashes (Evan Lucas) #2727 * crypto: Replace use of rwlocks, unsafe on Windows XP / 2003 (Ben Noordhuis) #2723 * libuv: Upgrade from 1.7.3 to 1.7.4 (Saúl Ibarra Corretgé) #2817 * node: Fix faulty process.release.libUrl on Windows (Rod Vagg) #2699 * node-gyp: Float v3.0.3 which has improved support for Node.js and io.js v0.10 to v4+ (Rod Vagg) #2700 * npm: Upgrade to version 2.14.3 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) #2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) #2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 PR-URL: #2698
20d9e78 to
9c0c21d
Compare
|
done, all built and promoted https://iojs.org/dist/latest/ |
* buffer: Fixed a minor errors that was causing crashes (Michaël Zasso) #2635, * child_process: Fix error that was causing crashes (Evan Lucas) #2727 * crypto: Replace use of rwlocks, unsafe on Windows XP / 2003 (Ben Noordhuis) #2723 * libuv: Upgrade from 1.7.3 to 1.7.4 (Saúl Ibarra Corretgé) #2817 * node: Fix faulty process.release.libUrl on Windows (Rod Vagg) #2699 * node-gyp: Float v3.0.3 which has improved support for Node.js and io.js v0.10 to v4+ (Rod Vagg) #2700 * npm: Upgrade to version 2.14.3 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) #2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) #2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 PR-URL: #2698
|
Yay! Thanks, @rvagg. |
|
|
derp |
@nodejs/release please can I have someone to take this and push it through early next week?
Commits:
b73ff52fe6] - bindings: close after reading module struct (Fedor Indutny) #2792aa1140e59a] - buffer: SlowBuffer only accept valid numeric values (Michaël Zasso) #2635574475d56e] - build: clean up the generated tap file (Sakthipriyan Vairamani) #2837aa0001271e] - build: remote commands on staging in single session (Rod Vagg) #27171428661095] - build: fix v8_enable_handle_zapping override (Karl Skomski) #27315a51edd718] - build: add --enable-asan with builtin leakcheck (Karl Skomski) #2376618caa5de0] - child_process: use stdio.fd even if it is 0 (Evan Lucas) #27277be4e49cb6] - child_process: check execFile and fork args (James M Snell) #26677f5d6e72c6] - cluster: allow shared reused dgram sockets (Fedor Indutny) #2548e68c7ec498] - contextify: ignore getters during initialization (Fedor Indutny) nodejs/io.js#2091610fa964aa] - cpplint: make it possible to run outside git repo (Ben Noordhuis) #27104237373dd7] - crypto: replace rwlocks with simple mutexes (Ben Noordhuis) #2723777eb00306] - deps: upgraded to node-gyp@3.0.3 in npm (Kat Marchán) #2822b729ad384b] - deps: upgrade to npm 2.14.3 (Kat Marchán) #2822b09fde761c] - deps: update libuv to version 1.7.4 (Saúl Ibarra Corretgé) #28174cf225daad] - deps: float node-gyp v3.0.0 (Rod Vagg) #2700118f48c0f3] - deps: create .npmrc during npm tests (Kat Marchán) #2696b3fee8e6a6] - deps: upgrade to npm 2.14.2 (Kat Marchán) #26964593539b92] - deps: backport 75e43a6 from v8 upstream (saper) #26362d1438cfe0] - doc: fix broken link in repl.markdown (Danny Nemer) #28279dd9c85a48] - doc: fix typos in README (Ionică Bizău) #2852476125d403] - doc: add tunniclm as a collaborator (Mike Tunnicliffe) #28260603a92d48] - doc: fix two doc errors in stream and process (Jeremiah Senkpiel) #2549da2902ddfd] - doc: use "Calls" over "Executes" for consistency (Minwoo Jung) #28005e93bc4fba] - doc: use US English for consistency (Anne-Gaelle Colom) #27843ee7fbcefd] - doc: use 3rd person singular for consistency (Anne-Gaelle Colom) #27654fdccb9eb7] - doc: fix comma splice in Assertion Testing doc (Rich Trott) #272828c2d310d6] - doc: update AUTHORS list (Rod Vagg)324c073fb9] - doc: add TSC meeting minutes 2015-09-02 (Rod Vagg) #26748929445686] - doc: update url doc to account for escaping (Jeremiah Senkpiel) #2605512dad6883] - doc: reorder collaborators by their usernames (Johan Bergström) #23228372ea2ca5] - doc,test: enable recursive file watching in Windows (Sakthipriyan Vairamani) #2649daf6c533cc] - events,lib: don't require EE#listenerCount() (Jeremiah Senkpiel) #2661d8371a801e] - http_server: fix resume after socket close (Fedor Indutny) #28247f7d4fdddd] - node-gyp: float 3.0.1, minor fix for download url (Rod Vagg) #273791cee73294] - src: use ZCtxt as a source for v8::Isolates (Roman Klauke) #2547ac98e13b95] - src: s/ia32/x86 for process.release.libUrl for win (Rod Vagg) #2699ca6c3223e1] - src: use standard conform snprintf on windows (Karl Skomski) #2404b028978a53] - src: fix buffer overflow for long exception lines (Karl Skomski) #2404e73eafd7e7] - src: fix memory leak in ExternString (Karl Skomski) #2402d370306de1] - src: only set v8 flags if argc > 1 (Evan Lucas) #2646ed087836af] - streams: refactor LazyTransform to internal/ (Brendan Ashworth) #2566993c22fe0e] - test: remove disabled test (Rich Trott) #28411474f29d1f] - test: split up internet dns tests (Rich Trott) #2802601a97622b] - test: increase dgram timeout for armv6 (Rich Trott) #28081dad19ba81] - test: remove valid hostname check in test-dns.js (Rich Trott) #2785f3d5891a3f] - test: expect error for test_lookup_ipv6_hint on FreeBSD (Rich Trott) #27242ffb21baf1] - test: fix use ofcommonbefore required (Rod Vagg) #2685b2c5479a14] - test: refactor to eliminate flaky test (Rich Trott) #2609fcfd15f8f9] - test: mark eval_messages as flaky (Alexis Campailla) #26481865cad7ae] - test: mark test-vm-syntax-error-stderr as flaky (João Reis) #2662b0014ecd27] - test: mark test-repl-persistent-history as flaky (João Reis) #265974ff9bc86c] - timers: minor _unrefActive fixes and improvements (Jeremiah Senkpiel) #25405d14a6eca7] - timers: don't mutate unref list while iterating it (Julien Gilli) #25406e744c58f2] - timers: Avoid linear scan in _unrefActive. (Julien Gilli) #254007fbf835ad] - tools: opentest.tapfile in write-binary mode (Sakthipriyan Vairamani) #28376d9198f7f1] - tools: add missing tick processor polyfill (Matt Loring) #26947b16597527] - tools: fix flakiness in test-tick-processor (Matt Loring) #2694ef83029356] - tools: remove hyphen in TAP result (Sakthipriyan Vairamani) #2718ac45ef9157] - win,msi: fix documentation shortcut url (Brian White) #2781Additional diff with master since 3.3.0:
845acb4e1e] - tools: enable arrow functions in .eslintrc (Sakthipriyan Vairamani) #28401f842c2c61] - (SEMVER-MAJOR) fs: consider NaN/Infinity in toUnixTimestamp (Yazhong Liu) #238705d30d5396] - (SEMVER-MINOR) fs: implemented WriteStream#writev (Ron Korving) #2167abb2a4b8fe] - doc: fixed io.js references in process.markdown (Tristian Flanagan) #28468e141356ff] - src: fix v8::CpuProfiler idle sampling (Oleksandr Chekhovskyi) #2324acb6779c19] - deps: cherry-pick 6da51b4 from v8's upstream (Fedor Indutny) #2801f442904a27] - doc: describe process API for IPC (Sam Roberts) #1978380a3d89c3] - 2015-09-08, Version 4.0.0 (Stable) Release (Rod Vagg) #274231450fce7c] - deps: improve ArrayBuffer performance in v8 (Fedor Indutny) #2732b3c4cecd82] - build: make .msi install to "nodejs", not "node" (Rod Vagg) #2701b4f1711a62] - deps: backport 75e43a6 from v8 upstream (again) (saper) #2692d65106e307] - build: fix .pkg creation tooling (Rod Vagg) #26876532e937e1] - doc: update environment vars in manpage and --help (Roman Reiss) #26904e3d767f4c] - deps: upgrade V8 to 4.5.103.30 (Ali Ijaz Sheikh) #2632439c1dde15] - src: re-enable fast math on arm (Michaël Zasso) #25926c1b26a12e] - (SEMVER-MAJOR) src: enable vector ics on arm again (Ali Ijaz Sheikh) #25094abc896a82] - src: replace usage of v8::Handle with v8::Local (Michaël Zasso) nodejs/io.js#22029a03ae6356] - src: enable v8 deprecation warnings and fix them (Ben Noordhuis) nodejs/io.js#2091d571680638] - (SEMVER-MAJOR) test: fix test-repl-tab-complete.js for V8 4.5 (Ali Ijaz Sheikh) #25090159ac9c99] - (SEMVER-MAJOR) src: apply debug force load fixups from 41e63fb (Ali Ijaz Sheikh) #25099fddd83cf9] - (SEMVER-MAJOR) deps: upgrade V8 to 4.5.103.24 (Ali Ijaz Sheikh) #2509607aa3ac82] - (SEMVER-MAJOR) child_process: add callback parameter to .send() (Ben Noordhuis) #2620a06e11d9d3] - doc: update changelog for io.js v3.3.0 (Rod Vagg) #265342a8a0a53e] - Working on v5.0.0 (Rod Vagg)de88255b0f] - _Revert_ "lib,src: add unix socket getsockname/getpeername" (Ben Noordhuis) #25846cd0e2664b] - doc: update io.js reference (Ben Noordhuis) #25807a999a1376] - (SEMVER-MAJOR) lib: add net.Socket#localFamily property (Ben Noordhuis) #956f337595441] - (SEMVER-MAJOR) lib,src: add unix socket getsockname/getpeername (Ben Noordhuis) #956b630ebaf43] - win,msi: Upgrade from old upgrade code (João Reis) #2439f9539c19e8] - doc: update changelog for io.js v3.2.0 (Rod Vagg) #2512cded6e7993] - doc: fix CHANGELOG.md on master (Roman Reiss) #251393e2830686] - (SEMVER-MINOR) doc: document deprecation of util.is* functions (Sakthipriyan Vairamani) #24473b602527d1] - (SEMVER-MAJOR) node: additional cleanup for node rename (cjihrig) #23674f50d3fb90] - (SEMVER-MAJOR) This commit sets the value of process.release.name to "node". (cjihrig) #236745a2046f5d] - (SEMVER-MAJOR) installer: fix installers for node.js rename (Frederic Hemberger) #2367a69ab27ab4] - (SEMVER-MAJOR) node: rename from io.js to node (cjihrig) #2367847459c29b] - (SEMVER-MAJOR) crypto: show exponent in decimal and hex (Chad Johnston) nodejs/io.js#2320d88194d261] - Working on v4.0.0 (Rod Vagg)