n-api: take n-api out of experimental by mhdawson · Pull Request #19262 · nodejs/node

mhdawson · 2018-03-09T17:45:34Z

Take n-api out of experimental as per:
nodejs/TSC#501

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
[X ] tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

mcollina

LGTM

cjihrig · 2018-03-09T17:49:06Z

src/node.cc

I think it would be better to combine the mp->nm_version == -1 check with the one in the else if

mhdawson · 2018-03-09T22:00:19Z

@cjihrig pushed commit to address your comment.

CI run: https://ci.nodejs.org/job/node-test-pull-request/13611/

richardlau · 2018-03-10T05:23:28Z

doc/api/n-api.md

Do we track changes like this in the documentation with YAML metadata?

Looking at the existing docs, I don't think so.

Take n-api out of experimental as per: nodejs/TSC#501

mhdawson · 2018-03-14T11:21:54Z

rebased, new ci

ci: https://ci.nodejs.org/job/node-test-pull-request/13673/

mhdawson · 2018-03-14T21:07:21Z

Faiure on linux was known issue: #18657. Rest of CI is green so we are good to go, will land.

mhdawson · 2018-03-14T21:14:53Z

land as cd7d7b1

Take n-api out of experimental as per: nodejs/TSC#501 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

targos · 2018-03-17T19:22:24Z

Do we want to land this on v9.x?

mcollina · 2018-03-17T21:55:20Z

I would recommend to land this on both 8 and 9.

Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #19447 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

mhdawson · 2018-06-01T12:37:28Z

@gabrielschulhof one of the two of us need to do this backport.

mhdawson · 2018-06-01T13:08:13Z

Working on backport PR

mhdawson · 2018-06-01T13:37:03Z

PR against v8.x-staging -> #21083.

@MylesBorins can you confirm PR against v8.x-staging is still the right way to go.

mhdawson · 2018-06-01T13:40:15Z

Not sure if backported tag should be added before PR lands so removed for now.

Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #21083 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

ryzokuken · 2018-06-11T18:38:38Z

Isn't this already backported successfully? Removing tag.

Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #21083 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) #18633 - remove runtime deprecation (Ali Ijaz Sheikh) #19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 * cluster: - add cwd to cluster.settings (cjihrig) #18399 - support windowsHide option for workers (Todd Wong) #17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) #18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) #21592 - upgrade libuv to 1.19.2 (cjihrig) #18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) #21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408 * http, http2: - add options to http.createServer() (Peter Marton) #15752 - add 103 Early Hints status code (Yosuke Furukawa) #16644 - add http fallback options to .createServer (Peter Marton) #15752 * n-api: - take n-api out of experimental (Michael Dawson) #19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) #18087 * src: - add public API for managing NodePlatform (Cheng Zhao) #16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) #17600 - node internals' postmortem metadata (Matheus Marchini) #14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) #19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) #18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) #18186 PR-URL: #21593

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) nodejs#18633 - remove runtime deprecation (Ali Ijaz Sheikh) nodejs#19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) nodejs#18513 * cluster: - add cwd to cluster.settings (cjihrig) nodejs#18399 - support windowsHide option for workers (Todd Wong) nodejs#17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) nodejs#18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) nodejs#21592 - upgrade libuv to 1.19.2 (cjihrig) nodejs#18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) nodejs#21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) nodejs#18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) nodejs#19408 * http, http2: - add options to http.createServer() (Peter Marton) nodejs#15752 - add 103 Early Hints status code (Yosuke Furukawa) nodejs#16644 - add http fallback options to .createServer (Peter Marton) nodejs#15752 * n-api: - take n-api out of experimental (Michael Dawson) nodejs#19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) nodejs#18087 * src: - add public API for managing NodePlatform (Cheng Zhao) nodejs#16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) nodejs#17600 - node internals' postmortem metadata (Matheus Marchini) nodejs#14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) nodejs#19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) nodejs#18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) nodejs#18186 PR-URL: nodejs#21593

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) #18633 - remove runtime deprecation (Ali Ijaz Sheikh) #19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 * cluster: - add cwd to cluster.settings (cjihrig) #18399 - support windowsHide option for workers (Todd Wong) #17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) #18644 * deps: - upgrade npm to 6.4.1 (Kat Marchán) #22591 - upgrade libuv to 1.19.2 (cjihrig) #18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) #21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408 * http, http2: - add options to http.createServer() (Peter Marton) #15752 - add 103 Early Hints status code (Yosuke Furukawa) #16644 - add http fallback options to .createServer (Peter Marton) #15752 * n-api: - take n-api out of experimental (Michael Dawson) #19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) #18087 * src: - add public API for managing NodePlatform (Cheng Zhao) #16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) #17600 - node internals' postmortem metadata (Matheus Marchini) #14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) #19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) #18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) #18186 PR-URL: #21593

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) #18633 - remove runtime deprecation (Ali Ijaz Sheikh) #19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 * cluster: - add cwd to cluster.settings (cjihrig) #18399 - support windowsHide option for workers (Todd Wong) #17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) #18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) #21592 - upgrade libuv to 1.19.2 (cjihrig) #18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) #21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408 * http, http2: - add options to http.createServer() (Peter Marton) #15752 - add 103 Early Hints status code (Yosuke Furukawa) #16644 - add http fallback options to .createServer (Peter Marton) #15752 * n-api: - take n-api out of experimental (Michael Dawson) #19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) #18087 * src: - add public API for managing NodePlatform (Cheng Zhao) #16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) #17600 - node internals' postmortem metadata (Matheus Marchini) #14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) #19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) #18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) #18186 PR-URL: #21593

Take n-api out of experimental as per: nodejs/TSC#501 PR-URL: nodejs/node#19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 9, 2018

mhdawson mentioned this pull request Mar 9, 2018

Bring N-API out of experimental nodejs/TSC#501

Closed

mcollina approved these changes Mar 9, 2018

View reviewed changes

cjihrig approved these changes Mar 9, 2018

View reviewed changes

src/node.cc Outdated

Copy link

Contributor

cjihrig Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to combine the mp->nm_version == -1 check with the one in the else if

targos approved these changes Mar 9, 2018

View reviewed changes

devsnek approved these changes Mar 9, 2018

View reviewed changes

jasnell approved these changes Mar 9, 2018

View reviewed changes

jasnell added this to the 10.0.0 milestone Mar 9, 2018

mhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2018

fhinkel approved these changes Mar 10, 2018

View reviewed changes

richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 10, 2018

richardlau reviewed Mar 10, 2018

View reviewed changes

mhdawson added 2 commits March 14, 2018 06:52

n-api: take n-api out of experimental

f28dfe5

Take n-api out of experimental as per: nodejs/TSC#501

squash: address comments

8220f5c

mhdawson force-pushed the napi-nexp branch from 0c78727 to 8220f5c Compare March 14, 2018 11:17

mhdawson added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 14, 2018

mhdawson closed this Mar 14, 2018

lovell mentioned this pull request Mar 16, 2018

N-API support lovell/farmhash#19

Closed

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2018

richardlau mentioned this pull request Apr 16, 2018

documentation of --napi-modules #20082

Closed

MylesBorins mentioned this pull request Apr 16, 2018

v6.14.2 proposal #19996

Merged

bnoordhuis mentioned this pull request Apr 18, 2018

src: kickstart addon by calling its constructor #20114

Closed

4 tasks

mhdawson mentioned this pull request Jun 1, 2018

[v8.x backport] n-api: take n-api out of experimental #21083

Closed

4 tasks

mhdawson added backported-to-v8.x and removed backported-to-v8.x labels Jun 1, 2018

ryzokuken removed backport-requested-v8.x labels Jun 11, 2018

mhdawson added the backported-to-v8.x label Jun 11, 2018

MylesBorins mentioned this pull request Jul 9, 2018

v8.12.0 proposal #21593

Merged

mhdawson deleted the napi-nexp branch September 30, 2019 13:15

Uh oh!

Conversation

mhdawson commented Mar 9, 2018

Checklist

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig Mar 9, 2018

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Mar 9, 2018

Uh oh!

richardlau Mar 10, 2018

Choose a reason for hiding this comment

Uh oh!

mhdawson Mar 14, 2018

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Mar 14, 2018

Uh oh!

mhdawson commented Mar 14, 2018

Uh oh!

mhdawson commented Mar 14, 2018

Uh oh!

targos commented Mar 17, 2018

Uh oh!

mcollina commented Mar 17, 2018

Uh oh!

mhdawson commented Jun 1, 2018

Uh oh!

mhdawson commented Jun 1, 2018

Uh oh!

mhdawson commented Jun 1, 2018

Uh oh!

mhdawson commented Jun 1, 2018

Uh oh!

ryzokuken commented Jun 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants