http,http2: Add 103 Early Hints status code by yosuke-furukawa · Pull Request #16644 · nodejs/node

yosuke-furukawa · 2017-10-31T16:41:37Z

Early Hints draft is approved by IESG and the draft is queued in RFC Editor.

https://datatracker.ietf.org/doc/draft-ietf-httpbis-early-hints/

I would like to add this feature in core, this is the first step, I would like to define this status code 103.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

http, http2

mscdex · 2017-10-31T16:44:37Z

I don't see why the rush, especially since it's still a draft in the experimental stage?

jasnell · 2017-10-31T16:52:08Z

Given that it's in the RFC Ed queue, I'm +1 on this. The new code has already been added to the IANA registry and all this is doing is adding the status code.

apapirovski

SGTM

watilde · 2017-11-01T16:22:25Z

ci: https://ci.nodejs.org/job/node-test-pull-request/11131/

joaocgreis · 2017-11-01T17:18:15Z

One Windows worker was going to fail because of an infra issue (nodejs/build#952). Aborted and relaunched the Windows job as https://ci.nodejs.org/job/node-test-commit-windows-fanned/13068/ .

apapirovski · 2017-11-04T15:22:27Z

Landed in 7eb5ee3

PR-URL: #16644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: nodejs#16644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: * CLI: - NODE_OPTIONS now supports the --stack-trace-limit option. nodejs#16495 * deps: - OpenSSL is upgraded to 1.0.2m nodejs#16691 * http: - A 'connect' event handler leak has been fixed. nodejs#16725 - The 103 Early Hints status code is now supported. nodejs#16644 PR-URL: nodejs#16851

Notable changes: * CLI: - NODE_OPTIONS now supports the --stack-trace-limit option. #16495 * deps: - OpenSSL is upgraded to 1.0.2m #16691 * http: - A 'connect' event handler leak has been fixed. #16725 - The 103 Early Hints status code is now supported. #16644 PR-URL: #16851

MylesBorins · 2017-11-14T17:51:15Z

Should this be semver minor?

jasnell · 2017-11-14T17:52:33Z

Still experimental status, so semver doesn't apply, but doesn't hurt. [Update] Nevermind, I forgot this adds it to http1 also... yes, semver-minor.

…

On Tue, Nov 14, 2017 at 9:51 AM, Myles Borins ***@***.***> wrote: Should this be semver minor? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16644 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2eZBLn38roKVJ8s2kk6eti_2Ytx6Mks5s2dMbgaJpZM4QNDq5> .

gibfahn · 2018-01-15T22:36:42Z

Release team were -1 on landing this in 6.x, but will look at it again for 8.x in the next semver-minor 8.x release.

evert · 2018-06-23T20:15:25Z

How would a user take advantage of this? I noticed that there's a sendContinue() function for emitting 100 Continue, but how would I emit 103 Early Hints ?

apapirovski · 2018-06-24T15:55:45Z

@evert the writeContinue is just there for compatibility mode and is just a thin wrapper over

stream.additionalHeaders({
  ':status': 100,
});

You could do something similar for 103.

evert · 2018-06-24T23:29:58Z

Thank you @apapirovski . Very appreciated!

PR-URL: #16644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) #18633 - remove runtime deprecation (Ali Ijaz Sheikh) #19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 * cluster: - add cwd to cluster.settings (cjihrig) #18399 - support windowsHide option for workers (Todd Wong) #17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) #18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) #21592 - upgrade libuv to 1.19.2 (cjihrig) #18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) #21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408 * http, http2: - add options to http.createServer() (Peter Marton) #15752 - add 103 Early Hints status code (Yosuke Furukawa) #16644 - add http fallback options to .createServer (Peter Marton) #15752 * n-api: - take n-api out of experimental (Michael Dawson) #19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) #18087 * src: - add public API for managing NodePlatform (Cheng Zhao) #16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) #17600 - node internals' postmortem metadata (Matheus Marchini) #14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) #19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) #18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) #18186 PR-URL: #21593

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) nodejs#18633 - remove runtime deprecation (Ali Ijaz Sheikh) nodejs#19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) nodejs#18513 * cluster: - add cwd to cluster.settings (cjihrig) nodejs#18399 - support windowsHide option for workers (Todd Wong) nodejs#17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) nodejs#18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) nodejs#21592 - upgrade libuv to 1.19.2 (cjihrig) nodejs#18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) nodejs#21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) nodejs#18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) nodejs#19408 * http, http2: - add options to http.createServer() (Peter Marton) nodejs#15752 - add 103 Early Hints status code (Yosuke Furukawa) nodejs#16644 - add http fallback options to .createServer (Peter Marton) nodejs#15752 * n-api: - take n-api out of experimental (Michael Dawson) nodejs#19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) nodejs#18087 * src: - add public API for managing NodePlatform (Cheng Zhao) nodejs#16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) nodejs#17600 - node internals' postmortem metadata (Matheus Marchini) nodejs#14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) nodejs#19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) nodejs#18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) nodejs#18186 PR-URL: nodejs#21593

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) #18633 - remove runtime deprecation (Ali Ijaz Sheikh) #19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 * cluster: - add cwd to cluster.settings (cjihrig) #18399 - support windowsHide option for workers (Todd Wong) #17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) #18644 * deps: - upgrade npm to 6.4.1 (Kat Marchán) #22591 - upgrade libuv to 1.19.2 (cjihrig) #18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) #21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408 * http, http2: - add options to http.createServer() (Peter Marton) #15752 - add 103 Early Hints status code (Yosuke Furukawa) #16644 - add http fallback options to .createServer (Peter Marton) #15752 * n-api: - take n-api out of experimental (Michael Dawson) #19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) #18087 * src: - add public API for managing NodePlatform (Cheng Zhao) #16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) #17600 - node internals' postmortem metadata (Matheus Marchini) #14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) #19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) #18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) #18186 PR-URL: #21593

Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) #18633 - remove runtime deprecation (Ali Ijaz Sheikh) #19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) #18513 * cluster: - add cwd to cluster.settings (cjihrig) #18399 - support windowsHide option for workers (Todd Wong) #17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) #18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) #21592 - upgrade libuv to 1.19.2 (cjihrig) #18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) #21055 * fs,net: - support as and as+ flags in stringToFlags() (Sarat Addepalli) #18801 - emit 'ready' for fs streams and sockets (Sameer Srivastava) #19408 * http, http2: - add options to http.createServer() (Peter Marton) #15752 - add 103 Early Hints status code (Yosuke Furukawa) #16644 - add http fallback options to .createServer (Peter Marton) #15752 * n-api: - take n-api out of experimental (Michael Dawson) #19262 * perf_hooks: - add warning when too many entries in the timeline (James M Snell) #18087 * src: - add public API for managing NodePlatform (Cheng Zhao) #16981 - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko) #17600 - node internals' postmortem metadata (Matheus Marchini) #14901 * tls: - expose Finished messages in TLSSocket (Anton Salikhmetov) #19102 * **trace_events**: - add file pattern cli option (Andreas Madsen) #18480 * util: - implement util.getSystemErrorName() (Joyee Cheung) #18186 PR-URL: #21593

http,http2: Add 103 Early Hints status code

22fc877

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 31, 2017

jasnell approved these changes Oct 31, 2017

View reviewed changes

apapirovski approved these changes Oct 31, 2017

View reviewed changes

cjihrig approved these changes Oct 31, 2017

View reviewed changes

addaleax approved these changes Oct 31, 2017

View reviewed changes

apapirovski closed this Nov 4, 2017

cjihrig mentioned this pull request Nov 6, 2017

v9.1.0 proposal #16851

Merged

MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 14, 2017

gibfahn added dont-land-on-v6.x labels Jan 15, 2018

MylesBorins added the dont-land-on-v8.x label Aug 2, 2018

MylesBorins mentioned this pull request Aug 16, 2018

v8.12.0 proposal #21593

Merged

trygve-lie mentioned this pull request May 26, 2020

HTTP 103 Early Hints nodejs/undici#196

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

http,http2: Add 103 Early Hints status code#16644

http,http2: Add 103 Early Hints status code#16644
yosuke-furukawa wants to merge 1 commit intonodejs:masterfrom
yosuke-furukawa:feat_add_103

yosuke-furukawa commented Oct 31, 2017

Uh oh!

mscdex commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

apapirovski left a comment

Uh oh!

watilde commented Nov 1, 2017

Uh oh!

joaocgreis commented Nov 1, 2017

Uh oh!

apapirovski commented Nov 4, 2017

Uh oh!

MylesBorins commented Nov 14, 2017

Uh oh!

jasnell commented Nov 14, 2017 via email •

edited

Loading

Uh oh!

gibfahn commented Jan 15, 2018

Uh oh!

evert commented Jun 23, 2018

Uh oh!

apapirovski commented Jun 24, 2018

Uh oh!

evert commented Jun 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

yosuke-furukawa commented Oct 31, 2017

Checklist

Affected core subsystem(s)

Uh oh!

mscdex commented Oct 31, 2017

Uh oh!

jasnell commented Oct 31, 2017

Uh oh!

apapirovski left a comment

Choose a reason for hiding this comment

Uh oh!

watilde commented Nov 1, 2017

Uh oh!

joaocgreis commented Nov 1, 2017

Uh oh!

apapirovski commented Nov 4, 2017

Uh oh!

MylesBorins commented Nov 14, 2017

Uh oh!

jasnell commented Nov 14, 2017 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gibfahn commented Jan 15, 2018

Uh oh!

evert commented Jun 23, 2018

Uh oh!

apapirovski commented Jun 24, 2018

Uh oh!

evert commented Jun 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

jasnell commented Nov 14, 2017 via email •

edited

Loading