deps: ICU 58.2 bump#10206

Closed

srl295 wants to merge 2 commits intonodejs:masterfrom

srl295:icu4c-58.2

Member

srl295 commented Dec 9, 2016 •

edited

Loading

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

CLDR 30.0.3 ( was 30.0.2)
Timezone 2016j ( was 2016g )

srl295 added wip i18n-api labels

srl295 self-assigned this

srl295 commented

View reviewed changes

Member Author

srl295 left a comment •

edited

Loading

Note: actual impact is smaller than what's here due to whitespace when it actually lands. I'll see if I can figure out how to reduce the whitespace churn here.

Guess i need to 'land' the PR on a branch with am … fix-whitespace .. and force push that branch back

nodejs-github-bot added the dont-land-on-v7.x label

Member Author

srl295 commented Dec 9, 2016 •

edited

Loading

58.2 was released http://site.icu-project.org/download/58

srl295 removed the wip label

Fishrock123 removed the dont-land-on-v7.x label

Fishrock123 closed this

Fishrock123 reopened this

Contributor

Fishrock123 commented Dec 12, 2016

Sorry about that.

@srl295 should this be backported to LTS?

Member

mhdawson commented Dec 12, 2016

Removing the whitespace changes would make it a lot easier to review.

srl295 force-pushed the icu4c-58.2 branch from 2e9240a to 5c79e43 Compare

December 14, 2016 16:47

srl295 added 2 commits

December 14, 2016 08:48


          deps: ICU 58.2 bump

cf8ab08

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )


          deps: Bump ICU download path to 58.2

* update configure to new path

PR-URL: nodejs#10206

srl295 force-pushed the icu4c-58.2 branch from 5c79e43 to 5366488 Compare

December 14, 2016 17:40

Member Author

srl295 commented Dec 14, 2016 •

edited

Loading

@Fishrock123 yes, i think it should be backported
@mhdawson try it now - should be a lot easier to review.

I used curl -L https://github.com/nodejs/node/pull/10206.patch | git am --whitespace=fix to "land" it on a new branch, the pushed that back. Is there an easier way to do this? If I can integrate it into the "howto upgrade ICU docs", we can make this the same way for the future.

mhdawson approved these changes

View reviewed changes

Member

mhdawson left a comment

LGTM

Fishrock123 added lts-watch-v4.x labels

Fishrock123 approved these changes

View reviewed changes

Contributor

Fishrock123 left a comment

CI: https://ci.nodejs.org/job/node-test-pull-request/5443/

jasnell approved these changes

View reviewed changes

Member

gibfahn commented Dec 23, 2016

@mhdawson To review without the whitespace changes you can just add ?w=1 to the end of the URL.

@srl295 I think fixing the whitespace issues is the right way to go, if people find it messy they can use the ?w=1 trick. Obviously hopefully once the issues have been fixed once then it won't continue to be a problem.

Member Author

srl295 commented Dec 23, 2016 via email

White space is always fixed when landing. So the issue is only around review. I've already pushed a commit that fixes whitespace

Member

jasnell commented Dec 27, 2016

CI : https://ci.nodejs.org/job/node-test-pull-request/5606/

Member Author

srl295 commented Dec 29, 2016

landed in 68f004f and c830179

srl295 closed this

srl295 deleted the icu4c-58.2 branch

December 29, 2016 22:32

srl295 added a commit that referenced this pull request


          deps: ICU 58.2 bump

68f004f

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

srl295 added a commit that referenced this pull request


          deps: ICU 58.2 bump download URL

c830179

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas mentioned this pull request

v7.4.0 release proposal #10589

Merged

evanlucas pushed a commit that referenced this pull request


          deps: ICU 58.2 bump

616fd7a

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas pushed a commit that referenced this pull request


          deps: ICU 58.2 bump download URL

96158f9

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas pushed a commit that referenced this pull request


          deps: ICU 58.2 bump

bce0013

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas pushed a commit that referenced this pull request


          deps: ICU 58.2 bump download URL

785975d

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

srl295 mentioned this pull request

Closed

4 tasks

srl295 added a commit to srl295/node that referenced this pull request


          deps: ICU 58.2 bump

1e8afd5

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

srl295 added a commit to srl295/node that referenced this pull request


          deps: ICU 58.2 bump download URL

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

srl295 mentioned this pull request

deps: v6.x backport of #9234/#10206 bump ICU to 58.2 🍒 #10887

Closed

2 tasks

MylesBorins pushed a commit that referenced this pull request


          deps: ICU 58.2 bump

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: ICU 58.2 bump download URL

d51c637

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: ICU 58.2 bump

31dd253

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: ICU 58.2 bump download URL

72b4de5

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request

v6.10.0 proposal #10974

Merged

MylesBorins pushed a commit that referenced this pull request


          deps: ICU 58.2 bump

ae477b7

Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: ICU 58.2 bump download URL

687137e

Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels

srl295 mentioned this pull request

Need to update source exclusions for ICU 61 #16937

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels