-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to the i18n implementation.Issues and PRs related to the i18n implementation.
Description
- Platform: all
- Subsystem: deps
#16876 landed ICU 60.1 but didn't update the source exclusions in icu_generic.gyp. As a result:
- too many files are built- increases binary size, and source size (this also controls what is checked into the repo)
- there's more exposure for platform build issues (probably a minor point)
This would cause NO change in actual behavior, because the files aren't actually executed (or their removal would have caused the build to fail).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to the i18n implementation.Issues and PRs related to the i18n implementation.