Fix main branch actions failures, other pre-commit tweaks #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
force-pushed
the
more-formatting-rules
branch
from
7d06cb2 to
feb0bd6
Compare
stefanv
approved these changes
Jun 3, 2023
This will help with pep8 naming convention compliance without breaking the user-facing API. Specifically, we can lowercase the names of the Bezier and CatmulClark functions without having to lowercase the string argument values to the CLI.
mfisher87
force-pushed
the
more-formatting-rules
branch
from
feb0bd6 to
411f3e3
Compare
This rule was causing GitHub Actions to fail on merge commit.
mfisher87
force-pushed
the
more-formatting-rules
branch
from
411f3e3 to
bbd66aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-commit-to-branchpre-commit check. It works OK until GitHub actions tries to run on a merge commit (on themainbranch), and this causes it to fail.end-of-file-fixerpre-commit fixer.evalcalls inbezierbuilderwith a lookup, decoupling function names from the "method" string being passed from the CLI. This sets us up to make those function names pep8-compliant at some point.